Bug 33883 - "Make sure to copy your API secret" message overlaps text
Summary: "Make sure to copy your API secret" message overlaps text
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: David Cook
URL:
Keywords:
Depends on: 33875
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-02 01:22 UTC by David Cook
Modified: 2023-12-28 20:47 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33883: "Make sure to copy your API secret" message overlaps text (3.34 KB, patch)
2023-06-02 14:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33883: "Make sure to copy your API secret" message overlaps text (3.95 KB, patch)
2023-06-02 14:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33883: "Make sure to copy your API secret" message overlaps text (4.03 KB, patch)
2023-06-02 14:48 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33883: "Make sure to copy your API secret" message overlaps text (4.06 KB, patch)
2023-06-06 06:25 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2023-06-02 01:22:14 UTC
After you generate an API key for a patron, the grey border around the message "Make sure to copy your API secret now. You won’t be able to see it again!" overlaps the "Description: " text below it. 

It's hard to see but it does look bad when you notice it.
Comment 1 Owen Leonard 2023-06-02 14:08:43 UTC
Created attachment 151982 [details] [review]
Bug 33883: "Make sure to copy your API secret" message overlaps text

This patch updates the markup on the patron API keys page so that it
uses standard classes for dialogs and page sections.

To test you must have RESTOAuth2ClientCredentials enabled.

- Apply the patch and locate a patron record.
- From their checkout or detail page, choose More -> Manage API keys
- Click "Generate a new client id/secret pair"
- Enter a description and click Save.
- You should see a message in a standard message-style dialog, "Make
  sure to copy your API secret now. You won’t be able to see it again!"
- The API key information should be displayed in a .page-section div.
- The table of existing keys should be displayed in a .page-section div.
Comment 2 Owen Leonard 2023-06-02 14:22:45 UTC
Created attachment 151983 [details] [review]
Bug 33883: "Make sure to copy your API secret" message overlaps text

This patch updates the markup on the patron API keys page so that it
uses standard classes for dialogs and page sections.

To test you must have RESTOAuth2ClientCredentials enabled.

- Apply the patch and locate a patron record.
- From their checkout or detail page, choose More -> Manage API keys
- Click "Generate a new client id/secret pair"
- Enter a description and click Save.
- You should see a message in a standard message-style dialog, "Make
  sure to copy your API secret now. You won’t be able to see it again!"
- The API key information should be displayed in a .page-section div.
- The table of existing keys should be displayed in a .page-section div.
Comment 3 Matt Blenkinsop 2023-06-02 14:48:14 UTC
Created attachment 151985 [details] [review]
Bug 33883: "Make sure to copy your API secret" message overlaps text

This patch updates the markup on the patron API keys page so that it
uses standard classes for dialogs and page sections.

To test you must have RESTOAuth2ClientCredentials enabled.

- Apply the patch and locate a patron record.
- From their checkout or detail page, choose More -> Manage API keys
- Click "Generate a new client id/secret pair"
- Enter a description and click Save.
- You should see a message in a standard message-style dialog, "Make
  sure to copy your API secret now. You won’t be able to see it again!"
- The API key information should be displayed in a .page-section div.
- The table of existing keys should be displayed in a .page-section div.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 4 David Cook 2023-06-06 06:25:32 UTC
Created attachment 152033 [details] [review]
Bug 33883: "Make sure to copy your API secret" message overlaps text

This patch updates the markup on the patron API keys page so that it
uses standard classes for dialogs and page sections.

To test you must have RESTOAuth2ClientCredentials enabled.

- Apply the patch and locate a patron record.
- From their checkout or detail page, choose More -> Manage API keys
- Click "Generate a new client id/secret pair"
- Enter a description and click Save.
- You should see a message in a standard message-style dialog, "Make
  sure to copy your API secret now. You won’t be able to see it again!"
- The API key information should be displayed in a .page-section div.
- The table of existing keys should be displayed in a .page-section div.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 Tomás Cohen Arazi 2023-06-06 13:01:32 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Tomás Cohen Arazi 2023-06-09 14:21:52 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-06-12 10:58:32 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x