Bug 33918 - Improve translation of title tags: Patron card creator
Summary: Improve translation of title tags: Patron card creator
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:03 UTC by Owen Leonard
Modified: 2023-09-25 12:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33918: Improve translation of title tags: Patron card creator (17.27 KB, patch)
2023-08-22 13:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33918: Improve translation of title tags: Patron card creator (17.43 KB, patch)
2023-09-12 14:27 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 33918: Improve translation of title tags: Patron card creator (17.49 KB, patch)
2023-09-21 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:03:00 UTC
This patch will modify patron card creator templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-08-22 13:20:55 UTC Comment hidden (obsolete)
Comment 2 Emily-Rose Francoeur 2023-09-12 14:27:01 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2023-09-21 21:52:57 UTC
Created attachment 156023 [details] [review]
Bug 33918: Improve translation of title tags: Patron card creator

This patch updates patron card creator templates so that title
tags can be more easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron card creator home page
  - New -> Card batch
  - New -> Image
  - New -> Layout
  - New -> Card template
  - New -> Printer profile
  - Manage -> Card batches
  - Manage -> Images
  - Manage -> Layouts
  - Manage -> Card templates
  - Manage -> Printer profiles

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-09-22 13:55:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-22 19:40:19 UTC
Enhancement not pushed to 23.05.x