Bug 3393 - Default branches and overdues notices
Summary: Default branches and overdues notices
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Ian Walls
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 6064
  Show dependency treegraph
 
Reported: 2009-07-06 08:13 UTC by Nahuel Angelinetti
Modified: 2013-02-02 08:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bugfix (4.10 KB, patch)
2009-07-06 08:20 UTC, Chris Cormack
Details | Diff | Splinter Review
Simple patch (1.21 KB, patch)
2010-09-09 18:04 UTC, Ian Walls
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:09:58 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2009-07-06 08:13:41 ----

For the moment, if default rules are set in the overduerules, the script overdues_notices.pl doesn't take care about it.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-07-06 08:20:18 ----

Created an attachment
bugfix





---- Additional Comments From katrin.fischer@bsz-bw.de 2009-10-29 08:56:19 ----

*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3035 has been marked as a duplicate of this bug. ***



---- Additional Comments From katrin.fischer@bsz-bw.de 2009-10-29 08:56:45 ----

*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2650 has been marked as a duplicate of this bug. ***



---- Additional Comments From katrin.fischer@bsz-bw.de 2009-10-29 08:57:09 ----

*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2471 has been marked as a duplicate of this bug. ***



---- Additional Comments From cnighswonger@foundations.edu 2010-02-12 14:26:26 ----

This does not appear to have made it into HEAD.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:09 UTC  ---

This bug was previously known as _bug_ 3393 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3393
Imported an attachment (id=1275)

Actual time not defined. Setting to 0.0
CC member bchurch@ptfs.com does not have an account here
CC member joe.atzberger@liblime.com does not have an account here
The original submitter of attachment 1275 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2010-07-07 16:43:35 UTC
Patch appears to have been approved on 3.0.x.

Patch for HEAD? http://lists.koha-community.org/pipermail/koha-patches/2010-June/012102.html
Comment 2 Nicole C. Engard 2010-09-09 17:49:35 UTC
This has not been patched in HEAD - I just hit this problem today!
Comment 3 Ian Walls 2010-09-09 18:04:27 UTC
Created attachment 2613 [details] [review]
Simple patch

This patch simply removes a restriction in GetBranchcodesWithOverdueRules to allow default rules to come through.
Comment 4 MJ Ray (software.coop) 2010-12-12 19:16:32 UTC
This bug is mentioned in:
Fixes bug 3393: Overdue_notices.pl not	respecting default notice rules http://lists.koha-community.org/pipermail/koha-patches/2010-November/013058.html
Comment 5 Nicole C. Engard 2010-12-16 14:59:10 UTC
nengard@debian:~/kohaclone$ git am -3 -i -u bug3393.patchCommit Body is:
--------------------------
Fixes bug 3393: Overdue_notices.pl not respecting default notice rules
--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying Fixes bug 3393: Overdue_notices.pl not respecting default notice rules
error: patch failed: C4/Overdues.pm:957
error: C4/Overdues.pm: patch does not apply
Using index info to reconstruct a base tree...
error: patch failed: C4/Overdues.pm:957
error: C4/Overdues.pm: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Cannot fall back to three-way merge.
Patch failed at 0001.
When you have resolved this problem run "git-am -i -3 --resolved".
If you would prefer to skip this patch, instead run "git-am -i -3 --skip".
nengard@debian:~/kohaclone$
Comment 6 Ian Walls 2011-04-13 15:44:05 UTC
It looks like another patch has fixed this issue; marking as resolved.