Bug 6064 - Improvement of default value usage in overdue
Summary: Improvement of default value usage in overdue
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on: 3393
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-05 12:43 UTC by Sophie MEYNIEUX
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Change default value in overduerules table for delayn (NULL instead of 0) and fix GetBranchcodesWithOverdueRules function (4.55 KB, patch)
2011-04-05 14:08 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2011-04-05 12:43:03 UTC
Overdue letters are sent twice because of wrong default values usage in overduerules tables. 

This patch modifies default values in database and looks for default rules to apply.

To reproduce the bug, define different overdue rules for branches and default site. Set different email address for KohaAdminEmail and branch email. Run overdue_notices.pl -n and look at messages generated in message_queue table
Comment 1 Sophie MEYNIEUX 2011-04-05 14:08:51 UTC
Created attachment 3695 [details] [review]
Change default value in overduerules table for delayn (NULL instead of 0) and fix GetBranchcodesWithOverdueRules function
Comment 2 Chris Cormack 2011-04-06 03:48:45 UTC
Not an enhancement, changing it to a bug, so it is still eligible for 3.4
Comment 3 Chris Cormack 2011-04-07 09:36:59 UTC
Pushed, please test
Comment 4 Jared Camins-Esakov 2012-12-31 00:11:54 UTC
There have been no further reports of problems so I am marking this bug resolved.