Bug 33947 - Move GetAllIssues to Koha
Summary: Move GetAllIssues to Koha
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33948 33949
Blocks: 16846
  Show dependency treegraph
 
Reported: 2023-06-08 07:46 UTC by Jonathan Druart
Modified: 2023-10-25 22:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33947: Remove GetAllIssues (2.98 KB, patch)
2023-06-08 11:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33947: Remove GetAllIssues (7.82 KB, patch)
2023-06-08 13:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33947: Remove GetAllIssues (7.83 KB, patch)
2023-10-01 06:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33947: Remove GetAllIssues (7.87 KB, patch)
2023-10-01 16:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 33947: Remove GetAllIssues (7.93 KB, patch)
2023-10-12 12:31 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 07:46:06 UTC

    
Comment 1 Jonathan Druart 2023-06-08 11:02:55 UTC
Created attachment 152156 [details] [review]
Bug 33947: Remove GetAllIssues

No more occurrences of GetAllIssues, remove it!

Test plan:
  git grep is your friend
Comment 2 Jonathan Druart 2023-06-08 12:17:59 UTC
All dependent patches applied on https://gitlab.com/joubu/Koha/-/commits/bug_33947
Comment 3 Jonathan Druart 2023-06-08 13:51:52 UTC
Created attachment 152195 [details] [review]
Bug 33947: Remove GetAllIssues

No more occurrences of GetAllIssues, remove it!

Test plan:
  git grep is your friend
Comment 4 David Nind 2023-09-30 21:32:11 UTC
Patch no longer applies 8-(..

Bug 33947 - Move GetAllIssues to Koha

152195 - Bug 33947: Remove GetAllIssues

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 33947: Remove GetAllIssues
Using index info to reconstruct a base tree...
M	C4/Members.pm
M	t/db_dependent/Members/GetAllIssues.t
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): t/db_dependent/Members/GetAllIssues.t deleted in Bug 33947: Remove GetAllIssues and modified in HEAD. Version HEAD of t/db_dependent/Members/GetAllIssues.t left in tree.
Auto-merging C4/Members.pm
CONFLICT (content): Merge conflict in C4/Members.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 33947: Remove GetAllIssues
Comment 5 Jonathan Druart 2023-10-01 06:17:10 UTC
Created attachment 156444 [details] [review]
Bug 33947: Remove GetAllIssues

No more occurrences of GetAllIssues, remove it!

Test plan:
  git grep is your friend
Comment 6 David Nind 2023-10-01 16:42:30 UTC
Created attachment 156445 [details] [review]
Bug 33947: Remove GetAllIssues

No more occurrences of GetAllIssues, remove it!

Test plan:
  git grep is your friend

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Nick Clemens (kidclamp) 2023-10-12 12:31:26 UTC
Created attachment 156959 [details] [review]
Bug 33947: Remove GetAllIssues

No more occurrences of GetAllIssues, remove it!

Test plan:
  git grep is your friend

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-10-20 14:03:51 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-25 22:17:13 UTC
Enhancement not pushed to 23.05.x