Bug 33949 - Replace GetAllIssues with Koha::Checkouts - opac
Summary: Replace GetAllIssues with Koha::Checkouts - opac
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33946 33951 33952 33953 33954 33955 33958
Blocks: 33947
  Show dependency treegraph
 
Reported: 2023-06-08 07:47 UTC by Jonathan Druart
Modified: 2023-10-25 07:58 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac (19.03 KB, patch)
2023-06-08 11:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac (18.83 KB, patch)
2023-06-08 12:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac (16.18 KB, patch)
2023-09-18 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33949: Fix display of old checkouts if no checkouts exist (1.48 KB, patch)
2023-09-18 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac (16.22 KB, patch)
2023-09-30 20:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 33949: Fix display of old checkouts if no checkouts exist (1.52 KB, patch)
2023-09-30 20:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac (16.28 KB, patch)
2023-10-12 12:29 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 33949: Fix display of old checkouts if no checkouts exist (1.58 KB, patch)
2023-10-12 12:29 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 07:47:03 UTC

    
Comment 1 Jonathan Druart 2023-06-08 11:02:35 UTC
Created attachment 152155 [details] [review]
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac

Same as bug 33948 for the OPAC side.
Additionally you will test
* OPACMySummaryHTML
* The different cover images services
* Display of ISBN
* Display of UPC
* Ratings
Comment 2 Jonathan Druart 2023-06-08 12:16:46 UTC
Created attachment 152177 [details] [review]
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac

Same as bug 33948 for the OPAC side.
Additionally you will test
* OPACMySummaryHTML
* The different cover images services
* Display of ISBN
* Display of UPC
* Ratings
Comment 3 Jonathan Druart 2023-09-18 09:43:50 UTC
Created attachment 155781 [details] [review]
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac

Same as bug 33948 for the OPAC side.
Additionally you will test
* OPACMySummaryHTML
* The different cover images services
* Display of ISBN
* Display of UPC
* Ratings
Comment 4 Jonathan Druart 2023-09-18 09:43:52 UTC
Created attachment 155782 [details] [review]
Bug 33949: Fix display of old checkouts if no checkouts exist

If we pass an empty array from the perl controller, we retrieve an empty
string from the template, and the merge does not work.

This patch fixes the following bug:
Pick a patron without checkout history
Check them an item out and check it in
=> The table is empty, whereas it should display the item that has been
checked in.
Comment 5 David Nind 2023-09-30 20:55:11 UTC
Created attachment 156440 [details] [review]
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac

Same as bug 33948 for the OPAC side.
Additionally you will test
* OPACMySummaryHTML
* The different cover images services
* Display of ISBN
* Display of UPC
* Ratings

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2023-09-30 20:55:13 UTC
Created attachment 156441 [details] [review]
Bug 33949: Fix display of old checkouts if no checkouts exist

If we pass an empty array from the perl controller, we retrieve an empty
string from the template, and the merge does not work.

This patch fixes the following bug:
Pick a patron without checkout history
Check them an item out and check it in
=> The table is empty, whereas it should display the item that has been
checked in.

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2023-09-30 21:23:58 UTC
I've signed off, but I had a couple of questions:

1. I'm not sure where I should be checking for the display of the ISBN and UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the indicators)).

2. Old checkouts - I was sure how to replicate this issue. After applying the patch, checking out and checking in an item, things displayed as expected. This worked the same before the patches were applied.


Testing notes (using KTD):

1. I added several checkouts for a patron and checked some items in.

2. I added some ratings in the OPAC for items displayed in the history.

3. Enabled a couple of the cover image services - Amazon, OpenLibrary, and local cover images.

4. After apply the patches, I noticed no differences in the display in the OPAC for the patron's Checkout history (including 'Show all items') and their Summary.

5. I noticed that local cover images are not displayed in the checkout history and summary pages - bug 32514 has already been created for this.
Comment 8 Jonathan Druart 2023-10-02 08:46:22 UTC
(In reply to David Nind from comment #7)
> I've signed off, but I had a couple of questions:

Thanks!

> 1. I'm not sure where I should be checking for the display of the ISBN and
> UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the
> indicators)).

Sorry, wrong test plan.
The UPC is used by BakerTaylor, and the ISBN for the cover images. They are not directly displayed on the UI.

> 2. Old checkouts - I was sure how to replicate this issue. After applying
> the patch, checking out and checking in an item, things displayed as
> expected. This worked the same before the patches were applied.

Yes, the second patch is a follow-up for the first patch. It's no fixing a bug that is in master.
Comment 9 David Nind 2023-10-02 20:40:27 UTC
Thanks Jonathan!
Comment 10 Nick Clemens (kidclamp) 2023-10-12 12:29:52 UTC
Created attachment 156957 [details] [review]
Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac

Same as bug 33948 for the OPAC side.
Additionally you will test
* OPACMySummaryHTML
* The different cover images services
* Display of ISBN
* Display of UPC
* Ratings

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 11 Nick Clemens (kidclamp) 2023-10-12 12:29:54 UTC
Created attachment 156958 [details] [review]
Bug 33949: Fix display of old checkouts if no checkouts exist

If we pass an empty array from the perl controller, we retrieve an empty
string from the template, and the merge does not work.

This patch fixes the following bug:
Pick a patron without checkout history
Check them an item out and check it in
=> The table is empty, whereas it should display the item that has been
checked in.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 12 Tomás Cohen Arazi 2023-10-18 18:44:02 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 13 Fridolin Somers 2023-10-25 07:58:07 UTC
Enhancement not pushed to 23.05.x