Currently the authorities page defaults to the first tab in the record, generally 0XX Some libraries would like this to default to the 1XX, or other tabs
Created attachment 152518 [details] [review] Bug 34075: Add DefaultAuthorityTab system preference This patch adds a new system preference, DefaultAuthorityTab. When set, this will choose the default display on the authorities details page. To test: 1 - Apply patch, update database 2 - View an authority detail 3 - You should default to the 0XX or first tab 4 - Set DefaultAuthorityTab to a number that there is no tab for in your authority 5 - Reload and verify details page loads the first tba 6 - Set DefaultAuthorityTab to 1XX or another tab that exists in your record 7 - Reload the details and confirm the correct tab is selected
I don't see an atomicupdate with this. Should there be?
Created attachment 152582 [details] [review] Bug 34075: Add DefaultAuthorityTab system preference This patch adds a new system preference, DefaultAuthorityTab. When set, this will choose the default display on the authorities details page. To test: 1 - Apply patch, update database 2 - View an authority detail 3 - You should default to the 0XX or first tab 4 - Set DefaultAuthorityTab to a number that there is no tab for in your authority 5 - Reload and verify details page loads the first tba 6 - Set DefaultAuthorityTab to 1XX or another tab that exists in your record 7 - Reload the details and confirm the correct tab is selected
(In reply to Owen Leonard from comment #2) > I don't see an atomicupdate with this. Should there be? Woops! Thanks Owen!
Created attachment 152584 [details] [review] Bug 34075: Add DefaultAuthorityTab system preference This patch adds a new system preference, DefaultAuthorityTab. When set, this will choose the default display on the authorities details page. To test: 1 - Apply patch, update database 2 - View an authority detail 3 - You should default to the 0XX or first tab 4 - Set DefaultAuthorityTab to a number that there is no tab for in your authority 5 - Reload and verify details page loads the first tba 6 - Set DefaultAuthorityTab to 1XX or another tab that exists in your record 7 - Reload the details and confirm the correct tab is selected Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152633 [details] [review] Bug 34075: (follow-up) Fixes for QA tool errors - Added missing filter to template variable - Correct spelling in atomicupdate
Created attachment 153625 [details] [review] Bug 34075: Add DefaultAuthorityTab system preference This patch adds a new system preference, DefaultAuthorityTab. When set, this will choose the default display on the authorities details page. To test: 1 - Apply patch, update database 2 - View an authority detail 3 - You should default to the 0XX or first tab 4 - Set DefaultAuthorityTab to a number that there is no tab for in your authority 5 - Reload and verify details page loads the first tba 6 - Set DefaultAuthorityTab to 1XX or another tab that exists in your record 7 - Reload the details and confirm the correct tab is selected Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 153626 [details] [review] Bug 34075: (follow-up) Fixes for QA tool errors - Added missing filter to template variable - Correct spelling in atomicupdate Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 153627 [details] [review] Bug 34075: Improve JS code Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
IMO this third patch improves the JS part. Feel free to drop it if you disagree.
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x