I believe this has to do with our changes for tabs: When an authority record is edited and saved, you get directed to the authority detail page, but only the tabs themselves and no contents show.
Created attachment 157181 [details] [review] Bug 35058: Automatically show authority tab 0 if DefaultAuthorityTab is empty The change to the authority detail page made by Bug 34075 didn't take into account the possibility that the DefaultAuthorityTab tab preference might be empty. This leads to a JavaScript error and no tabs being shown. We can avoid this situation by initializing the tab_object variable as an empty object. To test, apply the patch and go to Authorities to repeat the test plan for Bug 34075: 1. Locate and view the detail page for an authority record. 2. The page should default to the 0XX or first tab. 3. Go to Administration -> System preferences and set the DefaultAuthorityTab preference to a number that won't be found in your authority record (e.g. there are no 3XX tags defined). 4. Return to the detail page and verify that the first tab is displayed. 5. Set DefaultAuthorityTab to 1XX or greater, one that exists in your record. 6. Reload the detail page and confirm the correct tab is selected. 7. Test the case where DefaultAuthorityTab is undefined by directly updating the database. In koha-testing-docker you can run this command: echo "update systempreferences set value = 3 where variable = 'DefaultAuthorityTab';" | koha-mysql kohadev Return to the authority detail tab to confirm that the first tab is displayed.
Created attachment 157211 [details] [review] Bug 35058: Automatically show authority tab 0 if DefaultAuthorityTab is empty The change to the authority detail page made by Bug 34075 didn't take into account the possibility that the DefaultAuthorityTab tab preference might be empty. This leads to a JavaScript error and no tabs being shown. We can avoid this situation by initializing the tab_object variable as an empty object. To test, apply the patch and go to Authorities to repeat the test plan for Bug 34075: 1. Locate and view the detail page for an authority record. 2. The page should default to the 0XX or first tab. 3. Go to Administration -> System preferences and set the DefaultAuthorityTab preference to a number that won't be found in your authority record (e.g. there are no 3XX tags defined). 4. Return to the detail page and verify that the first tab is displayed. 5. Set DefaultAuthorityTab to 1XX or greater, one that exists in your record. 6. Reload the detail page and confirm the correct tab is selected. 7. Test the case where DefaultAuthorityTab is undefined by directly updating the database. In koha-testing-docker you can run this command: echo "update systempreferences set value = 3 where variable = 'DefaultAuthorityTab';" | koha-mysql kohadev Return to the authority detail tab to confirm that the first tab is displayed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Easy fix, going to PQA directly.
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 34075 not in 23.05.x