The phrase "Displaying [all|approved|pending|rejected] terms" was cut into individual words by bug 30733. However, in French, we need to be able to change the sentence structure (it would become something like "Displaying terms [all|approved|pending|rejected]").
Created attachment 152523 [details] [review] Bug 34079 - The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited
Tricky indeed. In my opinion, we should use the all phrase to have context and no %s : <h4> [% IF ( filter_approved_all ) %]<span>Displaying all terms</span>[% END %] [% IF ( filter_approved_ok ) %]<span>Displaying approved terms</span>[% END %] [% IF ( filter_approved_pending ) %]<span>Displaying pending terms</span>[% END %] [% IF ( filter_approved_rej ) %]<span>Displaying rejected terms</span>[% END %] </h4>
Created attachment 152527 [details] [review] Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.)
(In reply to Fridolin Somers from comment #2) > Tricky indeed. > > In my opinion, we should use the all phrase to have context and no %s : > > <h4> > [% IF ( filter_approved_all ) %]<span>Displaying all terms</span>[% END %] > [% IF ( filter_approved_ok ) %]<span>Displaying approved terms</span>[% END > %] > [% IF ( filter_approved_pending ) %]<span>Displaying pending terms</span>[% > END %] > [% IF ( filter_approved_rej ) %]<span>Displaying rejected terms</span>[% END > %] > </h4> Even better! I redid the patch.
Created attachment 152553 [details] [review] Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 155475 [details] [review] Bug 34079: The phrase "Displaying [all|approved|pending|rejected] terms" was separated This patch reunites the words for the sentence "Displaying [all|approved|pending|rejected] terms" in order to facilitate translating in languages that have a different syntax. To test: 1. Install a new language ./misc/translator/translate install xx-XX 2. Check the xx-XX-staff-prog.po file for the sentence --> All the words are individual strings 3. Apply patch 4. Update the po files ./misc/translator/translate update xx-XX 5. Check the xx-XX-staff-prog.po file again --> The sentence is reunited for each status (Displaying all terms, Displaying approved terms, etc.) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple working patch, passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x