Bug 34081 - Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses
Summary: Contextualization of "Approved" (one term) vs "Approved" (more than one term)...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Caroline Cyr La Rose
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-21 15:04 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.10
Circulation function:


Attachments
Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses (6.52 KB, patch)
2023-06-21 16:29 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses (6.60 KB, patch)
2023-06-22 12:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses (6.66 KB, patch)
2023-09-11 11:03 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-06-21 15:04:51 UTC
In the case of tags, the statuses are the same for one or more term.

For example, in the table of terms, the column "Status" contains the status for the one term. Whereas, on the right, in the "Terms summary", the statuses are for many terms.
Comment 1 Caroline Cyr La Rose 2023-06-21 16:29:18 UTC
Created attachment 152533 [details] [review]
Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses

To test:

1. Apply patch

2. Install language

   ./misc/translator/translate install xx-XX

3. Update po files

   ./misc/translator/translate update xx-XX

4. View the xx-XX-messages.po file

   --> Strings for tag statuses for one tag should be separated from strings for statuses for multiple tags, with context Tags (single) or Tags (multiple)

5. Change the strings so you know which is which

   For example, in French, the approved status for a single tag would be "Approuvé" and for multiple tags would be "Approuvés" (with the plural s at the end)

6. Apply translations

   ./misc/translator/translate install xx-XX

7. Add tags through the OPAC
   7.1. In another tab, go to the OPAC
   7.2. Log in
   7.3. Search for a record
   7.4. From the detailed record, click Add tags
   7.5. Enter a tag and click Add

8. In the staff interface, go to Tools > Tags

9. Approve/Reject the tag
   --> The status in the table and on the button should be the singular status, the status in the summary on the right should be plural
Comment 2 Owen Leonard 2023-06-22 12:02:30 UTC
Created attachment 152557 [details] [review]
Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses

To test:

1. Apply patch

2. Install language

   ./misc/translator/translate install xx-XX

3. Update po files

   ./misc/translator/translate update xx-XX

4. View the xx-XX-messages.po file

   --> Strings for tag statuses for one tag should be separated from
       strings for statuses for multiple tags, with context Tags
       (single) or Tags (multiple)

5. Change the strings so you know which is which

   For example, in French, the approved status for a single tag would
   be "Approuvé" and for multiple tags would be "Approuvés" (with the
   plural s at the end)

6. Apply translations

   ./misc/translator/translate install xx-XX

7. Add tags through the OPAC
   7.1. In another tab, go to the OPAC
   7.2. Log in
   7.3. Search for a record
   7.4. From the detailed record, click Add tags
   7.5. Enter a tag and click Add

8. In the staff interface, go to Tools > Tags

9. Approve/Reject the tag
   --> The status in the table and on the button should be the singular
       status, the status in the summary on the right should be plural

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2023-09-11 11:03:04 UTC
Created attachment 155476 [details] [review]
Bug 34081: Contextualization of "Approved" (one term) vs "Approved" (more than one term), and other tag statuses

To test:

1. Apply patch

2. Install language

   ./misc/translator/translate install xx-XX

3. Update po files

   ./misc/translator/translate update xx-XX

4. View the xx-XX-messages.po file

   --> Strings for tag statuses for one tag should be separated from
       strings for statuses for multiple tags, with context Tags
       (single) or Tags (multiple)

5. Change the strings so you know which is which

   For example, in French, the approved status for a single tag would
   be "Approuvé" and for multiple tags would be "Approuvés" (with the
   plural s at the end)

6. Apply translations

   ./misc/translator/translate install xx-XX

7. Add tags through the OPAC
   7.1. In another tab, go to the OPAC
   7.2. Log in
   7.3. Search for a record
   7.4. From the detailed record, click Add tags
   7.5. Enter a tag and click Add

8. In the staff interface, go to Tools > Tags

9. Approve/Reject the tag
   --> The status in the table and on the button should be the singular
       status, the status in the summary on the right should be plural

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-09-11 11:03:28 UTC
Simple patch, all working as expected.

Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2023-09-12 12:43:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-14 18:13:49 UTC
Pushed to 23.05.x for 23.05.04
Comment 7 Matt Blenkinsop 2023-09-15 10:21:47 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x