Bug 34206 - [22.11] Vendor options do not show on agreements and licenses form
Summary: [22.11] Vendor options do not show on agreements and licenses form
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
: 34350 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-07-05 15:54 UTC by Pedro Amorim
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission: 22.11.08
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 34206: Fix display of vendor options in agreements and licenses forms (2.26 KB, patch)
2023-07-05 15:57 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34206: Fix display of vendor options in agreements and licenses forms (2.33 KB, patch)
2023-07-05 16:09 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-07-05 15:54:13 UTC
This is specific to 22.11.x and resulted of bug 33355 being originally developed without bug 33103 in master, but when bug 33355 was rebased before pushed, it was rebased with bug 33101 in master.

It applied nicely, but bug 33101 was not pushed to 22.11 because it's an enhancement.
Comment 1 Pedro Amorim 2023-07-05 15:57:52 UTC
Created attachment 153066 [details] [review]
Bug 34206: Fix display of vendor options in agreements and licenses forms

Test plan:
1) Go to ERM licenses /cgi-bin/koha/erm/licenses
2) Click 'New license' and click the 'vendor' dropdown
3) Notice how it doesn't bring up any options
4) Apply patch and repeat test plan. Notice how now the vendor options show.
5) Repeat test plan for agreements

The test plan should be done using the 22.11.x branch
Comment 2 Pedro Amorim 2023-07-05 16:01:58 UTC
(In reply to Pedro Amorim from comment #0)
> This is specific to 22.11.x and resulted of bug 33355 being originally
> developed without bug 33103 in master, but when bug 33355 was rebased before
> pushed, it was rebased with bug 33101 in master.
> 
> It applied nicely, but bug 33101 was not pushed to 22.11 because it's an
> enhancement.

Typo: "bug 33101" should be "bug 33103"
Comment 3 Martin Renvoize (ashimema) 2023-07-05 16:09:46 UTC
Created attachment 153067 [details] [review]
Bug 34206: Fix display of vendor options in agreements and licenses forms

Test plan:
1) Go to ERM licenses /cgi-bin/koha/erm/licenses
2) Click 'New license' and click the 'vendor' dropdown
3) Notice how it doesn't bring up any options
4) Apply patch and repeat test plan. Notice how now the vendor options show.
5) Repeat test plan for agreements

The test plan should be done using the 22.11.x branch

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-07-05 16:10:25 UTC
All working, lets go for a push.
Comment 5 Martin Renvoize (ashimema) 2023-07-06 14:06:13 UTC
Pushed to 22.11.x for 22.11.08
Comment 6 Pedro Amorim 2023-07-24 08:30:21 UTC
*** Bug 34350 has been marked as a duplicate of this bug. ***