Bug 34289 - UI issue on checkin page when checking the forgive fines checkbox
Summary: UI issue on checkin page when checking the forgive fines checkbox
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-14 20:17 UTC by Lucas Gass
Modified: 2023-12-28 20:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09


Attachments
screenshot of the problem (19.29 KB, image/png)
2023-07-14 20:17 UTC, Lucas Gass
Details
Bug 34289: Add missing class to one condition of the checkin template (2.11 KB, patch)
2023-07-17 16:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34289: Add missing class to one condition of the checkin template (2.15 KB, patch)
2023-07-31 15:19 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34289: Add missing class to one condition of the checkin template (2.21 KB, patch)
2023-07-31 19:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-07-14 20:17:05 UTC
Created attachment 153509 [details]
screenshot of the problem

To recreate:

1. Turn on fines mode 
2. Go to returns.pl (/cgi-bin/koha/circ/returns.pl)
3. Expand the the options so you see 'Forgive overdue charges'.
4. Check that box and check in an item
5. The item is checked in but now the input "Enter item barcode" is smaller than it should be and has a yellow background.
Comment 1 Owen Leonard 2023-07-17 16:47:52 UTC
Created attachment 153570 [details] [review]
Bug 34289: Add missing class to one condition of the checkin template

The markup of the checkin template varies depending on the conditions of
the operation, and in one case the barcode field was missing the
"barcode" class. This patch adds it.

To test, apply the patch and make sure the finesMode system preference
is enabled.

- Go to returns.pl (/cgi-bin/koha/circ/returns.pl)
- Expand the the options so you see 'Forgive overdue charges'.
- Check that box and check in an item
- After checkin, the barcode field should keep the same style it had
  before the transaction.
- Note: The yellow background of the input when the "Forgive" checkbox
  is checked is to be expected.
Comment 2 Sam Lau 2023-07-31 15:19:20 UTC
Created attachment 154103 [details] [review]
Bug 34289: Add missing class to one condition of the checkin template

The markup of the checkin template varies depending on the conditions of
the operation, and in one case the barcode field was missing the
"barcode" class. This patch adds it.

To test, apply the patch and make sure the finesMode system preference
is enabled.

- Go to returns.pl (/cgi-bin/koha/circ/returns.pl)
- Expand the the options so you see 'Forgive overdue charges'.
- Check that box and check in an item
- After checkin, the barcode field should keep the same style it had
  before the transaction.
- Note: The yellow background of the input when the "Forgive" checkbox
  is checked is to be expected.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-07-31 19:52:33 UTC
Created attachment 154110 [details] [review]
Bug 34289: Add missing class to one condition of the checkin template

The markup of the checkin template varies depending on the conditions of
the operation, and in one case the barcode field was missing the
"barcode" class. This patch adds it.

To test, apply the patch and make sure the finesMode system preference
is enabled.

- Go to returns.pl (/cgi-bin/koha/circ/returns.pl)
- Expand the the options so you see 'Forgive overdue charges'.
- Check that box and check in an item
- After checkin, the barcode field should keep the same style it had
  before the transaction.
- Note: The yellow background of the input when the "Forgive" checkbox
  is checked is to be expected.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-08-15 09:13:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-17 19:49:11 UTC
Since we have now :

[% IF ( exemptfine ) %]
    <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" />
[% ELSIF ( dropboxmode ) %]
    <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" />
[% ELSE %]

There is no difference between those two lines since type="text" is default behavior.

Maybe merge into [% IF ( exemptfine || dropboxmode ) %]
Comment 6 Owen Leonard 2023-08-18 07:53:24 UTC
(In reply to Fridolin Somers from comment #5)

> Maybe merge into [% IF ( exemptfine || dropboxmode ) %]

Bug 34572
Comment 7 Pedro Amorim 2023-08-18 14:43:36 UTC
@Frido this bug appears to have been pushed to 23.05.x but not yet updated on here on bugzilla.
Comment 8 Fridolin Somers 2023-08-21 18:37:37 UTC
(In reply to Owen Leonard from comment #6)
> (In reply to Fridolin Somers from comment #5)
> 
> > Maybe merge into [% IF ( exemptfine || dropboxmode ) %]
> 
> Bug 34572

Great :D
Comment 9 Fridolin Somers 2023-08-21 18:39:21 UTC
(In reply to Pedro Amorim from comment #7)
> @Frido this bug appears to have been pushed to 23.05.x but not yet updated
> on here on bugzilla.

Oups indeed sorry
Comment 10 Fridolin Somers 2023-08-21 18:40:01 UTC
Pushed to 23.05.x for 23.05.03
Comment 11 Pedro Amorim 2023-08-28 10:23:02 UTC
Nice work everyone!

Pushed to 22.11.x for next release