Fridolin writes in Bug 34289 comment 5: Since we have now : [% IF ( exemptfine ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" /> [% ELSIF ( dropboxmode ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" /> [% ELSE %] There is no difference between those two lines since type="text" is default behavior. Maybe merge into [% IF ( exemptfine || dropboxmode ) %]
Created attachment 154589 [details] [review] Bug 34572: Simplify template logic around check-in input form This patch makes a minor simplifying change to the check-in template around how to style the barcode input field in dropbox or fine-exempt mode. To test, apply the patch and go to Circulation. - If necessary, check some items out to patrons so that you have items to check in. - Go to the check-in page and click the icon inside the barcode field to expand the panel of options. - Check the "book drop mode" checkbox. The barcode field should now be highlighted yellow. - Check in an item. When the page redisplays, the barcode field should have the same highlighted style. - If necessary, enable the finesMode system preference. - On the check-in page, in the panel of options, check the "Forgive overdue fines" checkbox. Test checking in again, confirming the same style consistency in the barcode field.
Created attachment 154639 [details] [review] Bug 34572: Simplify template logic around check-in input form This patch makes a minor simplifying change to the check-in template around how to style the barcode input field in dropbox or fine-exempt mode. To test, apply the patch and go to Circulation. - If necessary, check some items out to patrons so that you have items to check in. - Go to the check-in page and click the icon inside the barcode field to expand the panel of options. - Check the "book drop mode" checkbox. The barcode field should now be highlighted yellow. - Check in an item. When the page redisplays, the barcode field should have the same highlighted style. - If necessary, enable the finesMode system preference. - On the check-in page, in the panel of options, check the "Forgive overdue fines" checkbox. Test checking in again, confirming the same style consistency in the barcode field. Signed-off-by: Inkeri <inkeri.hakulinen@helsinki.fi>
Seems to work alright.
Created attachment 154811 [details] [review] Bug 34572: Simplify template logic around check-in input form This patch makes a minor simplifying change to the check-in template around how to style the barcode input field in dropbox or fine-exempt mode. To test, apply the patch and go to Circulation. - If necessary, check some items out to patrons so that you have items to check in. - Go to the check-in page and click the icon inside the barcode field to expand the panel of options. - Check the "book drop mode" checkbox. The barcode field should now be highlighted yellow. - Check in an item. When the page redisplays, the barcode field should have the same highlighted style. - If necessary, enable the finesMode system preference. - On the check-in page, in the panel of options, check the "Forgive overdue fines" checkbox. Test checking in again, confirming the same style consistency in the barcode field. Signed-off-by: Inkeri <inkeri.hakulinen@helsinki.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x