The cataloging plugins unimarc_field_123d.pl, unimarc_field_123e.pl, and unimarc_field_123f.pl all create a link to unimarc_field_123g.pl. It looks like the templates for each plugin are functionally identical, so at some time in the past it was decided that each could use the same plugin, but routed through 4 different scripts. These should be consolidated.
Created attachment 154971 [details] [review] Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window.
Created attachment 155142 [details] [review] Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window.
Created attachment 155573 [details] [review] Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window. Signed-off-by: David Nind <david@davidnind.com>
Not sure if we have a real dependency here on bug 34630 here?
Created attachment 156683 [details] [review] Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 156684 [details] [review] Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g This patch removes some UNIMARC cataloging plugins which were essentially duplicates of each other and renaming the remaining version to reflect that it's for use with multiple subfields. UNIMARC 123$d, e, f, and g can all be filled with unimarc_field_123defg.pl It's easiest to test if you have UNIMARC sample data. In KTD, run 'reset_all_unimarc' - Apply the patch and run the database update process. - Go to Cataloging and create or edit a bibliographic record. - Under tab 1, look for tag 123. - Test the plugin link for subfields d, e, f, and g - In each case the popup window should have the heading "UNIMARC field 123d/e/f/g builder" - Fill out the form each time and confirm that the values are copied to the correct field in the MARC editor window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 156685 [details] [review] Bug 34657: (QA follow-up) Fix plugin link in UNIMARC default framework Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x