Bug 34657 - Merge cataloging plugins for UNIMARC 123d, e, f, and g
Summary: Merge cataloging plugins for UNIMARC 123d, e, f, and g
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34630
  Show dependency treegraph
 
Reported: 2023-08-30 14:26 UTC by Owen Leonard
Modified: 2023-10-14 12:14 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g (24.52 KB, patch)
2023-08-30 15:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g (25.18 KB, patch)
2023-09-01 17:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g (25.23 KB, patch)
2023-09-12 19:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g (25.29 KB, patch)
2023-10-07 15:38 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g (25.29 KB, patch)
2023-10-07 15:42 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34657: (QA follow-up) Fix plugin link in UNIMARC default framework (1.89 KB, patch)
2023-10-07 15:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-08-30 14:26:14 UTC
The cataloging plugins unimarc_field_123d.pl, unimarc_field_123e.pl, and unimarc_field_123f.pl all create a link to unimarc_field_123g.pl.

It looks like the templates for each plugin are functionally identical, so at some time in the past it was decided that each could use the same plugin, but routed through 4 different scripts.

These should be consolidated.
Comment 1 Owen Leonard 2023-08-30 15:31:13 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-09-01 17:36:32 UTC
Created attachment 155142 [details] [review]
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g

This patch removes some UNIMARC cataloging plugins which were
essentially duplicates of each other and renaming the remaining version
to reflect that it's for use with multiple subfields.

UNIMARC 123$d, e, f, and g can all be filled with
unimarc_field_123defg.pl

It's easiest to test if you have UNIMARC sample data. In KTD, run
'reset_all_unimarc'

- Apply the patch and run the database update process.
- Go to Cataloging and create or edit a bibliographic record.
- Under tab 1, look for tag 123.
- Test the plugin link for subfields d, e, f, and g
  - In each case the popup window should have the heading "UNIMARC field
    123d/e/f/g builder"
  - Fill out the form each time and confirm that the values are copied
    to the correct field in the MARC editor window.
Comment 3 David Nind 2023-09-12 19:42:27 UTC
Created attachment 155573 [details] [review]
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g

This patch removes some UNIMARC cataloging plugins which were
essentially duplicates of each other and renaming the remaining version
to reflect that it's for use with multiple subfields.

UNIMARC 123$d, e, f, and g can all be filled with
unimarc_field_123defg.pl

It's easiest to test if you have UNIMARC sample data. In KTD, run
'reset_all_unimarc'

- Apply the patch and run the database update process.
- Go to Cataloging and create or edit a bibliographic record.
- Under tab 1, look for tag 123.
- Test the plugin link for subfields d, e, f, and g
  - In each case the popup window should have the heading "UNIMARC field
    123d/e/f/g builder"
  - Fill out the form each time and confirm that the values are copied
    to the correct field in the MARC editor window.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-10-07 15:29:39 UTC
Not sure if we have a real dependency here on bug 34630 here?
Comment 5 Katrin Fischer 2023-10-07 15:38:18 UTC
Created attachment 156683 [details] [review]
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g

This patch removes some UNIMARC cataloging plugins which were
essentially duplicates of each other and renaming the remaining version
to reflect that it's for use with multiple subfields.

UNIMARC 123$d, e, f, and g can all be filled with
unimarc_field_123defg.pl

It's easiest to test if you have UNIMARC sample data. In KTD, run
'reset_all_unimarc'

- Apply the patch and run the database update process.
- Go to Cataloging and create or edit a bibliographic record.
- Under tab 1, look for tag 123.
- Test the plugin link for subfields d, e, f, and g
  - In each case the popup window should have the heading "UNIMARC field
    123d/e/f/g builder"
  - Fill out the form each time and confirm that the values are copied
    to the correct field in the MARC editor window.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-10-07 15:42:28 UTC
Created attachment 156684 [details] [review]
Bug 34657: Merge cataloging plugins for UNIMARC 123d, e, f, and g

This patch removes some UNIMARC cataloging plugins which were
essentially duplicates of each other and renaming the remaining version
to reflect that it's for use with multiple subfields.

UNIMARC 123$d, e, f, and g can all be filled with
unimarc_field_123defg.pl

It's easiest to test if you have UNIMARC sample data. In KTD, run
'reset_all_unimarc'

- Apply the patch and run the database update process.
- Go to Cataloging and create or edit a bibliographic record.
- Under tab 1, look for tag 123.
- Test the plugin link for subfields d, e, f, and g
  - In each case the popup window should have the heading "UNIMARC field
    123d/e/f/g builder"
  - Fill out the form each time and confirm that the values are copied
    to the correct field in the MARC editor window.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2023-10-07 15:42:32 UTC
Created attachment 156685 [details] [review]
Bug 34657: (QA follow-up) Fix plugin link in UNIMARC default framework

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-10-09 14:43:37 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-09 18:46:51 UTC
Enhancement not pushed to 23.05.x