In preparation for Bug 34566 I'd like to make a global change to the cataloging plugins: Add a "value_builder" class to the <body> tag and remove the inline style, "padding:1em" The inline style creates layout problems when the page has a fixed Bootstrap footer. An update to staff-global.scss will adding padding to the .value_builder class.
Created attachment 154888 [details] [review] Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254
Created attachment 154974 [details] [review] Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254
Created attachment 155139 [details] [review] Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254
Created attachment 155565 [details] [review] Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254 Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Created attachment 156686 [details] [review] Bug 34630: Update MARC21 cataloging plugin templates with consistent body class This patch updates cataloging plugin templates to remove the inline style "padding:1em" from the body tag. This style conflicts with fixed Bootstrap footers. A "value_builder" class is added to the body tag instead, the style added to staff-global.scss. There shouldn't be any visible change to the appearance of the pages. To test, apply the patch and rebuild the staff interface CSS and clear your browser cache if necessary. - Go to Cataloging -> New record. - In a default MARC21 installation you can test various plugin popups to confirm that they display correctly: - 000 - 006 - 007 - 008 To visually confirm each affected template, the plugins can be loaded in their own tab for testing the appearance of the page. I have a list of direct links here: https://gitlab.com/-/snippets/2555254 Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x
Not sure this is much different from bug 34566, manual-wise. Feel free to reopen with more details if needed.