Bug 34630 - Update MARC21 cataloging plugin templates with consistent body class
Summary: Update MARC21 cataloging plugin templates with consistent body class
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 34657
Blocks: 34566
  Show dependency treegraph
 
Reported: 2023-08-28 14:40 UTC by Owen Leonard
Modified: 2023-12-13 22:20 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class (61.39 KB, patch)
2023-08-28 15:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class (59.00 KB, patch)
2023-08-30 15:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class (58.96 KB, patch)
2023-09-01 17:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class (59.12 KB, patch)
2023-09-12 17:30 UTC, Emily-Rose Francoeur
Details | Diff | Splinter Review
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class (59.17 KB, patch)
2023-10-07 17:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-08-28 14:40:11 UTC
In preparation for Bug 34566 I'd like to make a global change to the cataloging plugins:

Add a "value_builder" class to the <body> tag and remove the inline style, "padding:1em" The inline style creates layout problems when the page has a fixed Bootstrap footer.

An update to staff-global.scss will adding padding to the .value_builder class.
Comment 1 Owen Leonard 2023-08-28 15:53:28 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-08-30 15:45:25 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2023-09-01 17:09:00 UTC
Created attachment 155139 [details] [review]
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class

This patch updates cataloging plugin templates to remove the inline
style "padding:1em" from the body tag. This style conflicts with fixed
Bootstrap footers.

A "value_builder" class is added to the body tag instead, the style
added to staff-global.scss. There shouldn't be any visible change to the
appearance of the pages.

To test, apply the patch and rebuild the staff interface CSS and clear
your browser cache if necessary.

- Go to Cataloging -> New record.
- In a default MARC21 installation you can test various plugin popups to
    confirm that they display correctly:
    - 000
    - 006
    - 007
    - 008

To visually confirm each affected template, the plugins can be loaded in
their own tab for testing the appearance of the page. I have a list of
direct links here:

https://gitlab.com/-/snippets/2555254
Comment 4 Emily-Rose Francoeur 2023-09-12 17:30:02 UTC
Created attachment 155565 [details] [review]
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class

This patch updates cataloging plugin templates to remove the inline
style "padding:1em" from the body tag. This style conflicts with fixed
Bootstrap footers.

A "value_builder" class is added to the body tag instead, the style
added to staff-global.scss. There shouldn't be any visible change to the
appearance of the pages.

To test, apply the patch and rebuild the staff interface CSS and clear
your browser cache if necessary.

- Go to Cataloging -> New record.
- In a default MARC21 installation you can test various plugin popups to
    confirm that they display correctly:
    - 000
    - 006
    - 007
    - 008

To visually confirm each affected template, the plugins can be loaded in
their own tab for testing the appearance of the page. I have a list of
direct links here:

https://gitlab.com/-/snippets/2555254
Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 5 Katrin Fischer 2023-10-07 17:24:45 UTC
Created attachment 156686 [details] [review]
Bug 34630: Update MARC21 cataloging plugin templates with consistent body class

This patch updates cataloging plugin templates to remove the inline
style "padding:1em" from the body tag. This style conflicts with fixed
Bootstrap footers.

A "value_builder" class is added to the body tag instead, the style
added to staff-global.scss. There shouldn't be any visible change to the
appearance of the pages.

To test, apply the patch and rebuild the staff interface CSS and clear
your browser cache if necessary.

- Go to Cataloging -> New record.
- In a default MARC21 installation you can test various plugin popups to
    confirm that they display correctly:
    - 000
    - 006
    - 007
    - 008

To visually confirm each affected template, the plugins can be loaded in
their own tab for testing the appearance of the page. I have a list of
direct links here:

https://gitlab.com/-/snippets/2555254
Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-10-09 14:43:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-09 18:47:21 UTC
Enhancement not pushed to 23.05.x
Comment 8 Caroline Cyr La Rose 2023-12-13 22:20:13 UTC
Not sure this is much different from bug 34566, manual-wise. Feel free to reopen with more details if needed.