Bug 34725 - Remove use of onclick for OPAC cart
Summary: Remove use of onclick for OPAC cart
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: David Cook
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34709 34726
  Show dependency treegraph
 
Reported: 2023-09-06 06:46 UTC by David Cook
Modified: 2023-10-12 16:01 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.11


Attachments
Bug 34725: Remove use of onclick for OPAC cart (3.16 KB, patch)
2023-09-06 06:58 UTC, David Cook
Details | Diff | Splinter Review
Bug 34725: Remove use of onclick for OPAC cart (3.22 KB, patch)
2023-09-07 12:25 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34725: Remove use of onclick for OPAC cart (3.27 KB, patch)
2023-09-17 14:13 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2023-09-06 06:46:56 UTC
Like bug 34570, we want to get rid of "onclick".
Comment 1 David Cook 2023-09-06 06:58:15 UTC
Created attachment 155256 [details] [review]
Bug 34725: Remove use of onclick for OPAC cart

This patch moves the click handler in the OPAC cart from the inline HTML
and out to an existing <script> element.

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Add the results to the cart
3. Click on the "Cart"
4. One by one click on the title of each row
5. Notice how the parent window changes to the detail record for that title
Comment 2 Pedro Amorim 2023-09-07 12:25:05 UTC
Created attachment 155297 [details] [review]
Bug 34725: Remove use of onclick for OPAC cart

This patch moves the click handler in the OPAC cart from the inline HTML
and out to an existing <script> element.

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Add the results to the cart
3. Click on the "Cart"
4. One by one click on the title of each row
5. Notice how the parent window changes to the detail record for that title

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Katrin Fischer 2023-09-17 14:13:02 UTC
Created attachment 155757 [details] [review]
Bug 34725: Remove use of onclick for OPAC cart

This patch moves the click handler in the OPAC cart from the inline HTML
and out to an existing <script> element.

Test plan:
0. Apply the patch
1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1
2. Add the results to the cart
3. Click on the "Cart"
4. One by one click on the title of each row
5. Notice how the parent window changes to the detail record for that title

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-09-18 15:04:26 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-18 20:40:26 UTC
Pushed to 23.05.x for 23.05.04
Comment 6 Matt Blenkinsop 2023-10-12 16:01:06 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x