Like bug 34570, we want to get rid of "onclick".
Created attachment 155256 [details] [review] Bug 34725: Remove use of onclick for OPAC cart This patch moves the click handler in the OPAC cart from the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Add the results to the cart 3. Click on the "Cart" 4. One by one click on the title of each row 5. Notice how the parent window changes to the detail record for that title
Created attachment 155297 [details] [review] Bug 34725: Remove use of onclick for OPAC cart This patch moves the click handler in the OPAC cart from the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Add the results to the cart 3. Click on the "Cart" 4. One by one click on the title of each row 5. Notice how the parent window changes to the detail record for that title Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 155757 [details] [review] Bug 34725: Remove use of onclick for OPAC cart This patch moves the click handler in the OPAC cart from the inline HTML and out to an existing <script> element. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Add the results to the cart 3. Click on the "Cart" 4. One by one click on the title of each row 5. Notice how the parent window changes to the detail record for that title Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x