In the table settings, under Acquisition table, the first column of the orders table is basket_number. But in the table, in a basket, this column doesn't show the basket number but the order line. The name of this column should be order_line.
Created attachment 155916 [details] [review] Bug 34748: Fix column name in columns configuration for basket table The first column was named basket_number, but it's actually the order_line. To test: * Edit column configuration for acquisition > basket * Make sure to set at least one checkbox for 'basket_number' * Apply patch, run database update * Verify that the first column is now 'order_line', but your settings have been preserved
Created attachment 155919 [details] [review] Bug 34748: Fix column name in columns configuration for basket table The first column was named basket_number, but it's actually the order_line. To test: * Edit column configuration for acquisition > basket * Make sure to set at least one checkbox for 'basket_number' * Apply patch, run database update * Verify that the first column is now 'order_line', but your settings have been preserved Signed-off-by: David Nind <david@davidnind.com>
I can't seem to properly sign-off the patch, but I tested it on a sandbox and it works. Thanks you
Created attachment 156041 [details] [review] Bug 34748: Fix column name in columns configuration for basket table The first column was named basket_number, but it's actually the order_line. To test: * Edit column configuration for acquisition > basket * Make sure to set at least one checkbox for 'basket_number' * Apply patch, run database update * Verify that the first column is now 'order_line', but your settings have been preserved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04 Maybe depends on Bug 31932
Nice work everyone! Pushed to oldstable for 22.11.x