Bug 34910 - Do not allow checkout for anonymous patron
Summary: Do not allow checkout for anonymous patron
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-26 07:52 UTC by Fridolin Somers
Modified: 2023-11-13 15:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 34910: Do not allow checkout for anonymous patron (1.98 KB, patch)
2023-09-27 06:08 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34910: Do not allow checkout for anonymous patron (2.33 KB, patch)
2023-09-27 06:13 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34910: (follow-up) alert in patron details (1.95 KB, patch)
2023-09-27 06:13 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34910: Do not allow checkout for anonymous patron (2.39 KB, patch)
2023-09-27 13:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34910: (follow-up) alert in patron details (2.01 KB, patch)
2023-09-27 13:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34910: Do not allow checkout for anonymous patron (2.45 KB, patch)
2023-10-13 10:50 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34910: (follow-up) alert in patron details (2.08 KB, patch)
2023-10-13 10:50 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 34910: Do not allow checkout for anonymous patron (2.54 KB, patch)
2023-10-13 10:50 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 34910: (follow-up) alert in patron details (2.16 KB, patch)
2023-10-13 10:50 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 34910: Do not allow checkout for anonymous patron (2.59 KB, patch)
2023-10-14 16:00 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34910: (follow-up) alert in patron details (2.21 KB, patch)
2023-10-14 16:00 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34910: Do not allow checkout for anonymous patron (2.66 KB, patch)
2023-10-14 16:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34910: (follow-up) alert in patron details (2.28 KB, patch)
2023-10-14 16:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-09-26 07:52:21 UTC
The anonymous patron circulation page should show an alert message and not allow check-out.
Comment 1 Fridolin Somers 2023-09-26 07:52:53 UTC
Bug 11009 did this for circulation history
Comment 2 Fridolin Somers 2023-09-27 06:08:47 UTC
Created attachment 156253 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron
Comment 3 Fridolin Somers 2023-09-27 06:13:34 UTC
Created attachment 156254 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron

The anonymous patron circulation page should show an alert message and not allow check-out.

1) Configure an existing borrowernumber in system preference
   AnonymousPatron
2) Go to circulation page of this borrower :
   /cgi-bin/koha/circ/circulation.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron, so circulation is disabled.'
Comment 4 Fridolin Somers 2023-09-27 06:13:47 UTC
Created attachment 156255 [details] [review]
Bug 34910: (follow-up) alert in patron details

The anonymous patron details page should show an alert message.

1) Configure an existing borrowernumber in system preference 'AnonymousPatron'
2) Go to details page of this borrower :
   /cgi-bin/koha/members/moremember.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron.'
Comment 5 Fridolin Somers 2023-09-27 06:15:48 UTC
BTW we may also change in circulation history, not show the patron details when it is the anonymous.
Just write 'Anonymized'.
Comment 6 ByWater Sandboxes 2023-09-27 13:24:18 UTC
Created attachment 156289 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron

The anonymous patron circulation page should show an alert message and not allow check-out.

1) Configure an existing borrowernumber in system preference
   AnonymousPatron
2) Go to circulation page of this borrower :
   /cgi-bin/koha/circ/circulation.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron, so circulation is disabled.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Comment 7 ByWater Sandboxes 2023-09-27 13:24:20 UTC
Created attachment 156290 [details] [review]
Bug 34910: (follow-up) alert in patron details

The anonymous patron details page should show an alert message.

1) Configure an existing borrowernumber in system preference 'AnonymousPatron'
2) Go to details page of this borrower :
   /cgi-bin/koha/members/moremember.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Comment 8 David Nind 2023-10-07 01:26:56 UTC
Hi Kelly.

It looks like you've signed off but haven't updated the status...

David
Comment 9 ByWater Sandboxes 2023-10-13 10:50:11 UTC
Created attachment 157059 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron

The anonymous patron circulation page should show an alert message and not allow check-out.

1) Configure an existing borrowernumber in system preference
   AnonymousPatron
2) Go to circulation page of this borrower :
   /cgi-bin/koha/circ/circulation.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron, so circulation is disabled.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi>
Comment 10 ByWater Sandboxes 2023-10-13 10:50:13 UTC
Created attachment 157060 [details] [review]
Bug 34910: (follow-up) alert in patron details

The anonymous patron details page should show an alert message.

1) Configure an existing borrowernumber in system preference 'AnonymousPatron'
2) Go to details page of this borrower :
   /cgi-bin/koha/members/moremember.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi>
Comment 11 PTFS Europe Sandboxes 2023-10-13 10:50:21 UTC
Created attachment 157061 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron

The anonymous patron circulation page should show an alert message and not allow check-out.

1) Configure an existing borrowernumber in system preference
   AnonymousPatron
2) Go to circulation page of this borrower :
   /cgi-bin/koha/circ/circulation.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron, so circulation is disabled.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi>
Comment 12 PTFS Europe Sandboxes 2023-10-13 10:50:23 UTC
Created attachment 157062 [details] [review]
Bug 34910: (follow-up) alert in patron details

The anonymous patron details page should show an alert message.

1) Configure an existing borrowernumber in system preference 'AnonymousPatron'
2) Go to details page of this borrower :
   /cgi-bin/koha/members/moremember.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi>
Comment 13 Johanna Miettunen 2023-10-13 10:52:04 UTC
Works exactly as described.
Comment 14 Katrin Fischer 2023-10-14 16:00:05 UTC
This works as described, but only solves the issue on template side. 

We now have an API route for checkouts, should we add something there as well? ILS-DI?

A small glitch that we could also fix separately: The messages on details/checkouts show up in different spots, one below and one above the heading. But this is also the case for other existing messages on these pages now.
Comment 15 Katrin Fischer 2023-10-14 16:00:52 UTC
Created attachment 157156 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron

The anonymous patron circulation page should show an alert message and not allow check-out.

1) Configure an existing borrowernumber in system preference
   AnonymousPatron
2) Go to circulation page of this borrower :
   /cgi-bin/koha/circ/circulation.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron, so circulation is disabled.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Katrin Fischer 2023-10-14 16:00:55 UTC
Created attachment 157157 [details] [review]
Bug 34910: (follow-up) alert in patron details

The anonymous patron details page should show an alert message.

1) Configure an existing borrowernumber in system preference 'AnonymousPatron'
2) Go to details page of this borrower :
   /cgi-bin/koha/members/moremember.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 17 Katrin Fischer 2023-10-14 16:02:13 UTC
Created attachment 157158 [details] [review]
Bug 34910: Do not allow checkout for anonymous patron

The anonymous patron circulation page should show an alert message and not allow check-out.

1) Configure an existing borrowernumber in system preference
   AnonymousPatron
2) Go to circulation page of this borrower :
   /cgi-bin/koha/circ/circulation.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron, so circulation is disabled.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi>
Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 18 Katrin Fischer 2023-10-14 16:02:16 UTC
Created attachment 157159 [details] [review]
Bug 34910: (follow-up) alert in patron details

The anonymous patron details page should show an alert message.

1) Configure an existing borrowernumber in system preference 'AnonymousPatron'
2) Go to details page of this borrower :
   /cgi-bin/koha/members/moremember.pl?borrowernumber=x
3) Check you see alert 'This is the anonymous patron.'

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Johanna Miettunen <johanna.miettunen@haaga-helia.fi>
Signed-off-by: Päivi Knuutinen <paivi.knuutinen@joensuu.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 19 Tomás Cohen Arazi 2023-10-18 13:23:23 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 20 Fridolin Somers 2023-11-08 07:11:00 UTC
Pushed to 23.05.x for 23.05.06
Comment 21 Matt Blenkinsop 2023-11-13 15:23:15 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x