Bug 35010 - In record checkout history should not show anonymous patron link
Summary: In record checkout history should not show anonymous patron link
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
: 32410 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-10-09 08:56 UTC by Fridolin Somers
Modified: 2024-07-04 20:40 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11
Circulation function:


Attachments
Bug 35010: In record checkout history do not show anonymous patron link (2.20 KB, patch)
2023-10-09 09:02 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 35010: In record checkout history do not show anonymous patron link (2.25 KB, patch)
2023-10-09 10:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35010: In record checkout history do not show anonymous patron link (2.30 KB, patch)
2023-10-09 19:27 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-10-09 08:56:35 UTC
In a biblio record checkout history, when a checkout is anonymized the patron id has been replaced by anonymous patron id.
In this case we should not show anonymous patron link.
It looks like a real patron did this checkout.
Comment 1 Fridolin Somers 2023-10-09 08:57:08 UTC
Also see Bug 34910 for more anonymous related
Comment 2 Fridolin Somers 2023-10-09 09:02:29 UTC
Created attachment 156724 [details] [review]
Bug 35010: In record checkout history do not show anonymous patron link

In a biblio record checkout history, when a checkout is anonymized the patron id has been replaced by anonymous patron id.
In this case we should not show anonymous patron link.
It looks like a real patron did this checkout.

Test plan :
1) Set an existing patron id in system preference 'AnonymousPatron'
2) Perform anonymisation on old checkouts (or edit database manually)
3) Look at a record checkout history with old checkouts
=> You see 'Anonymized' for anonymized checkouts
4) Set system preference 'AnonymousPatron' empty
5) Look at same record checkout history
=> Check no error
Comment 3 Owen Leonard 2023-10-09 10:43:23 UTC
Created attachment 156729 [details] [review]
Bug 35010: In record checkout history do not show anonymous patron link

In a biblio record checkout history, when a checkout is anonymized the
patron id has been replaced by anonymous patron id.
In this case we should not show anonymous patron link.
It looks like a real patron did this checkout.

Test plan :
1) Set an existing patron id in system preference 'AnonymousPatron'
2) Perform anonymisation on old checkouts (or edit database manually)
3) Look at a record checkout history with old checkouts
=> You see 'Anonymized' for anonymized checkouts
4) Set system preference 'AnonymousPatron' empty
5) Look at same record checkout history
=> Check no error

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2023-10-09 19:27:50 UTC
Created attachment 156760 [details] [review]
Bug 35010: In record checkout history do not show anonymous patron link

In a biblio record checkout history, when a checkout is anonymized the
patron id has been replaced by anonymous patron id.
In this case we should not show anonymous patron link.
It looks like a real patron did this checkout.

Test plan :
1) Set an existing patron id in system preference 'AnonymousPatron'
2) Perform anonymisation on old checkouts (or edit database manually)
3) Look at a record checkout history with old checkouts
=> You see 'Anonymized' for anonymized checkouts
4) Set system preference 'AnonymousPatron' empty
5) Look at same record checkout history
=> Check no error

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-10-10 12:23:12 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-12 20:35:51 UTC
Pushed to 23.05.x for 23.05.05
Comment 7 Katrin Fischer 2023-10-13 14:02:40 UTC
*** Bug 32410 has been marked as a duplicate of this bug. ***
Comment 8 Matt Blenkinsop 2023-10-17 17:36:25 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x