Bug 34969 - t/Search/buildQuery.t does not do anything with Test::DBIx::Class
Summary: t/Search/buildQuery.t does not do anything with Test::DBIx::Class
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 34336
  Show dependency treegraph
 
Reported: 2023-09-30 06:48 UTC by Marcel de Rooy
Modified: 2023-10-17 17:12 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34969: Remove unneeded module from buildQuery.t (1.33 KB, patch)
2023-09-30 06:53 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 34969: Remove unneeded module from buildQuery.t (1.35 KB, patch)
2023-10-03 10:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests (1.09 KB, patch)
2023-10-03 10:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-09-30 06:48:21 UTC
No fixtures here too (see 34968).
Comment 1 Marcel de Rooy 2023-09-30 06:53:39 UTC
Created attachment 156437 [details] [review]
Bug 34969: Remove unneeded module from buildQuery.t

Test plan:
Run t/Search/buildQuery.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-09-30 06:54:03 UTC
Trivial: Self signoff
Comment 3 Katrin Fischer 2023-10-03 10:16:37 UTC
Created attachment 156491 [details] [review]
Bug 34969: Remove unneeded module from buildQuery.t

Test plan:
Run t/Search/buildQuery.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-10-03 10:16:42 UTC
Created attachment 156492 [details] [review]
Bug 34969: (QA follow-up) Re-add removed use_ok and can_ok tests

No need to remove them for removing Test::DBIx::Class dependency.
Tests still pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-10-03 12:41:41 UTC
Marcel commented on the removed tests on another bug - removing my follo-up:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968#c4
Comment 6 Tomás Cohen Arazi 2023-10-04 13:15:18 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-10-05 20:07:48 UTC
Pushed to 23.05.x for 23.05.05
Comment 8 Matt Blenkinsop 2023-10-17 17:12:20 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x