Bug 35413 - Terminology: differentiate issues for vendor issues and serials
Summary: Terminology: differentiate issues for vendor issues and serials
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 12:23 UTC by Katrin Fischer
Modified: 2024-01-04 20:20 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35413: Terminology: Manage issues (issue_manage) (3.98 KB, patch)
2023-11-28 15:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35413: Terminology: Manage issues (issue_manage) (4.03 KB, patch)
2023-11-29 09:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 35413: Terminology: Manage issues (issue_manage) (4.09 KB, patch)
2023-12-18 13:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35413: DB update (1.17 KB, patch)
2023-12-18 13:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-28 12:23:15 UTC
It would be clearer to change the description to:

Manage vendor issues (issue_manage)

The problem here is that issues can already be different things. In the past it meant checkouts, now most of the time it means serial issues. Having the standalone string is hard to translate and easy to confuse.
Comment 1 Owen Leonard 2023-11-28 15:49:10 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-11-29 09:41:28 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2023-12-05 15:07:56 UTC
Thx for fixing the navigation! I ran into this today as it's the same string for serials and vendor issues currently. This will help a lot.
Comment 4 Victor Grousset/tuxayo 2023-12-09 19:36:30 UTC
Shouldn't there be a database migration for existing installs? Because they will still have the old description:

select * from permissions where code = 'issue_manage';
| module_bit | code         | description   |
|         11 | issue_manage | Manage issues |

Or maybe it doesn't matter because where is permissions.description used anyway?

The test plan seems to looks in the right places and they don't use permissions.description.


Otherwise, all looks good.
Comment 5 Tomás Cohen Arazi 2023-12-18 13:07:16 UTC
Created attachment 159964 [details] [review]
Bug 35413: Terminology: Manage issues (issue_manage)

This patch updates several files which use the term "issues" without
context, changing them to "Vendor issues." Unchanged is the vendor
issues page template, vendor_issues.tt, which is updated in Bug 35417.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- You should see a "Vendor issues" link in the sidebar.
- Go to Patrons and search for a patron. View the patron's details.
- Click More -> Set permissions.
- Under Acquisitions management you should see "Manage vendor issues
  (issue_manage)"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2023-12-18 13:07:19 UTC
Created attachment 159965 [details] [review]
Bug 35413: DB update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2023-12-18 13:08:26 UTC
(In reply to Victor Grousset/tuxayo from comment #4)
> Shouldn't there be a database migration for existing installs? Because they
> will still have the old description:

Done. I don't think it is really an issue (cuack) but until we remove the unused column, we should always keep updated DB similar to fresh installs.
Comment 8 Katrin Fischer 2023-12-18 14:25:24 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2024-01-03 14:45:43 UTC
Pushed to 23.11.x for 23.11.02
Comment 10 Lucas Gass 2024-01-04 20:20:09 UTC
Doesn't apply cleanly to 23.05.x, no backport.