Bug 35417 - Update breadcrumbs and page titles for vendor issues
Summary: Update breadcrumbs and page titles for vendor issues
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 13:08 UTC by Katrin Fischer
Modified: 2024-01-04 20:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35417: Update breadcrumbs and page titles for vendor issues (5.17 KB, patch)
2023-11-28 15:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35417: Update breadcrumbs and page titles for vendor issues (5.22 KB, patch)
2023-11-29 09:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 35417: Update breadcrumbs and page titles for vendor issues (5.29 KB, patch)
2023-12-19 15:09 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-28 13:08:07 UTC
We still have these lines in translations:

%s %s Modify vendor issue %s New vendor issue %s › %s %s Confirm deletion of vendor issue › %s %s Vendor issue › Acquisition › Koha  

Shows that we need to update them to the new structure still :)
Comment 1 Owen Leonard 2023-11-28 15:39:05 UTC
Created attachment 159302 [details] [review]
Bug 35417: Update breadcrumbs and page titles for vendor issues

This patch updates the vendor issues template so that title and
breadcrumbs follow the same pattern on other updated templates:
Translatable strings in the title and breadcrumbs using the template
WRAPPER.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- Click the "Isssues" link in the sidebar.
- Check that the page title and breadcrumbs are correct in each
  variation of the page:
  - The main page
  - New vendor issue
  - Modify vendor issue
  - Issue deletion confirmation
Comment 2 David Nind 2023-11-29 09:50:48 UTC
Created attachment 159320 [details] [review]
Bug 35417: Update breadcrumbs and page titles for vendor issues

This patch updates the vendor issues template so that title and
breadcrumbs follow the same pattern on other updated templates:
Translatable strings in the title and breadcrumbs using the template
WRAPPER.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- Click the "Isssues" link in the sidebar.
- Check that the page title and breadcrumbs are correct in each
  variation of the page:
  - The main page
  - New vendor issue
  - Modify vendor issue
  - Issue deletion confirmation

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2023-12-19 15:09:03 UTC
Created attachment 160012 [details] [review]
Bug 35417: Update breadcrumbs and page titles for vendor issues

This patch updates the vendor issues template so that title and
breadcrumbs follow the same pattern on other updated templates:
Translatable strings in the title and breadcrumbs using the template
WRAPPER.

To test, apply the patch and go to Acquisitions.

- Search for a vendor and view the details.
- Click the "Isssues" link in the sidebar.
- Check that the page title and breadcrumbs are correct in each
  variation of the page:
  - The main page
  - New vendor issue
  - Modify vendor issue
  - Issue deletion confirmation

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-12-19 15:09:28 UTC
Thanks Owen, Passing QA.. all working as expected :)
Comment 5 Katrin Fischer 2023-12-20 14:15:03 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 15:28:35 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-04 20:53:47 UTC
Doesn't apply cleanly to 23.05.x, no backport.