Bug 35557 - LoadResultsCovers is not used (staff)
Summary: LoadResultsCovers is not used (staff)
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Julian Maurice
URL:
Keywords:
Depends on:
Blocks: 35558
  Show dependency treegraph
 
Reported: 2023-12-13 10:03 UTC by Jonathan Druart
Modified: 2024-01-04 21:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 35557: Remove LoadResultsCovers (3.42 KB, patch)
2023-12-13 10:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35557: Remove LoadResultsCovers (3.42 KB, patch)
2023-12-13 10:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35557: Remove LoadResultsCovers (3.47 KB, patch)
2023-12-15 20:35 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35557: Remove LoadResultsCovers (3.53 KB, patch)
2023-12-22 09:31 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 35557: Remove references to unused PREF_LocalCoverImages (2.50 KB, patch)
2023-12-22 09:32 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-12-13 10:03:54 UTC
The JS function LoadResultsCovers is not used from the Staff interface.

It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag.
Comment 1 Jonathan Druart 2023-12-13 10:06:36 UTC
Created attachment 159783 [details] [review]
Bug 35557: Remove LoadResultsCovers

The JS function LoadResultsCovers is not used from the Staff interface.

It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag.

Test plan:
Confirm that LoadResultsCovers was called but had no effect.
Note that the selector ^local-thumbnail only exists in shelfbrowser.inc

but results.js is only used from results.tt (not shelfbrowser.inc)

 Current status: ASSIGNED
Comment 2 Jonathan Druart 2023-12-13 10:07:03 UTC
Created attachment 159784 [details] [review]
Bug 35557: Remove LoadResultsCovers

The JS function LoadResultsCovers is not used from the Staff interface.

It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag.

Test plan:
Confirm that LoadResultsCovers was called but had no effect.
Note that the selector ^local-thumbnail only exists in shelfbrowser.inc

but results.js is only used from results.tt (not shelfbrowser.inc)
Comment 3 Tomás Cohen Arazi 2023-12-15 20:35:41 UTC
Created attachment 159913 [details] [review]
Bug 35557: Remove LoadResultsCovers

The JS function LoadResultsCovers is not used from the Staff interface.

It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag.

Test plan:
Confirm that LoadResultsCovers was called but had no effect.
Note that the selector ^local-thumbnail only exists in shelfbrowser.inc

but results.js is only used from results.tt (not shelfbrowser.inc)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Julian Maurice 2023-12-22 09:31:59 UTC
Created attachment 160225 [details] [review]
Bug 35557: Remove LoadResultsCovers

The JS function LoadResultsCovers is not used from the Staff interface.

It is supposed to load the local cover images in JS but actually we are embedding the thumbnail in the img tag.

Test plan:
Confirm that LoadResultsCovers was called but had no effect.
Note that the selector ^local-thumbnail only exists in shelfbrowser.inc

but results.js is only used from results.tt (not shelfbrowser.inc)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 5 Julian Maurice 2023-12-22 09:32:01 UTC
Created attachment 160226 [details] [review]
Bug 35557: Remove references to unused PREF_LocalCoverImages

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Katrin Fischer 2023-12-27 18:10:24 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 15:39:41 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass 2024-01-04 21:09:50 UTC
Backported to 23.05.x for upcoming 23.05.08