Bug 35795 - Missing closing tag in OPAC course details template
Summary: Missing closing tag in OPAC course details template
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 34855
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-12 16:34 UTC by Owen Leonard
Modified: 2024-02-09 20:40 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35795: Missing closing tag in OPAC course details template (1.59 KB, patch)
2024-01-12 16:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35795: Missing closing tag in OPAC course details template (1.64 KB, patch)
2024-01-12 17:14 UTC, David Nind
Details | Diff | Splinter Review
Bug 35795: Missing closing tag in OPAC course details template (1.74 KB, patch)
2024-01-19 10:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-01-12 16:34:26 UTC
There is a missing </em> in the breadcrumbs of the OPAC course details template. This causes all the following markup to be styled in italics.
Comment 1 Owen Leonard 2024-01-12 16:40:45 UTC
Created attachment 160989 [details] [review]
Bug 35795: Missing closing tag in OPAC course details template

This patch adds a missing closing tag, "</em>" to the breadcrumb
navigation shown when viewing the detail page of a course.

To test you must have at least one course created in the course reserves
module (Course reserves -> New course)

- Apply the patch and go to the OPAC.
- Open the Course reserves page and click the name of the course you
  created.
- The last item in the breadcrumb menu should be "Course reserves for
  [your course name]" and "you_course_name" should be in italics.
- The rest of the page should look correct.
Comment 2 David Nind 2024-01-12 17:14:39 UTC
Created attachment 160991 [details] [review]
Bug 35795: Missing closing tag in OPAC course details template

This patch adds a missing closing tag, "</em>" to the breadcrumb
navigation shown when viewing the detail page of a course.

To test you must have at least one course created in the course reserves
module (Course reserves -> New course)

- Apply the patch and go to the OPAC.
- Open the Course reserves page and click the name of the course you
  created.
- The last item in the breadcrumb menu should be "Course reserves for
  [your course name]" and "you_course_name" should be in italics.
- The rest of the page should look correct.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-01-19 10:45:05 UTC
Created attachment 161203 [details] [review]
Bug 35795: Missing closing tag in OPAC course details template

This patch adds a missing closing tag, "</em>" to the breadcrumb
navigation shown when viewing the detail page of a course.

To test you must have at least one course created in the course reserves
module (Course reserves -> New course)

- Apply the patch and go to the OPAC.
- Open the Course reserves page and click the name of the course you
  created.
- The last item in the breadcrumb menu should be "Course reserves for
  [your course name]" and "you_course_name" should be in italics.
- The rest of the page should look correct.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-01-26 14:18:09 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-31 14:12:25 UTC
Pushed to 23.11.x for 23.11.03
Comment 6 Lucas Gass 2024-02-09 20:40:28 UTC
Doesn't apply cleanly to 23.05.x, no backport.