Bug 34855 - Use template wrapper for breadcrumbs: OPAC part 3
Summary: Use template wrapper for breadcrumbs: OPAC part 3
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Sandbox
Depends on: 34849
Blocks: 35795
  Show dependency treegraph
 
Reported: 2023-09-20 18:44 UTC by Owen Leonard
Modified: 2024-01-12 16:34 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34855: Use template wrapper for breadcrumbs: OPAC part 3 (20.99 KB, patch)
2023-09-21 14:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34855: Use template wrapper for breadcrumbs: OPAC part 3 (23.02 KB, patch)
2023-09-21 15:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34855: Use template wrapper for breadcrumbs: OPAC part 3 (23.07 KB, patch)
2023-10-31 23:28 UTC, David Nind
Details | Diff | Splinter Review
Bug 34855: Use template wrapper for breadcrumbs: OPAC part 3 (23.13 KB, patch)
2023-11-01 22:44 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 34855: (QA follow-up) Terminology: "issue note" to "checkout note" (3.12 KB, patch)
2023-11-01 22:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-20 18:44:36 UTC
To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use the new template wrapper for breadcrumbs.

- opac-course-details.tt
- opac-course-reserves.tt
- opac-detail.tt
- opac-downloadshelf.tt
- opac-full-serial-issues.tt
- opac-imageviewer.tt
- opac-issue-note.tt
- opac-library.tt
- opac-main.tt
- opac-overdrive-search.tt
- opac-page.tt
- opac-passwd.tt
- opac-recall.tt
- opac-reportproblem.tt
Comment 1 Owen Leonard 2023-09-21 14:47:41 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-09-21 15:00:39 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-10-31 23:28:02 UTC
Created attachment 158164 [details] [review]
Bug 34855: Use template wrapper for breadcrumbs: OPAC part 3

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

This patch also updates html_helpers.inc to add some logic for handling
the case where the "Home" link is the only breadcrumb (on the OPAC main
page). The change allows for the link to be disabled in this case.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- OPAC main page
- Course reserves
  - Course reserves details
- Libraries
  - Follow the link for a specific library
- View the details of a bibliographic record
- Navigate directly to
  /cgi-bin/koha/opac-downloadshelf.pl?shelfnumber=X where X is the id of
  an existing list. (I don't think this page is ever seen unless the
  user has JavaScript disabled).
- Locate a serial record and click the "More details" link under the
  "Subscriptions" tab.
  - Click the "Full history" tab.
- Log into the OPAC as a user with checkouts. Navigate directly to
  /cgi-bin/koha/opac-issue-note.pl?issue_id=X where X is the id
  (issue_id) of one of the user's checkouts. (Another page which is only
  accessed directly if the user has JS disabled).
- From the logged-in user summary page, click "Change password"
  - Submit a password change.
- With "UseRecalls" enabled, locate a bibliographic record you can place
  a recall request for.
  - Place a recall.
- With "OPACLocalCoverImages" enabled, locate a bibliographic record
  which has a local cover image attached.
  - Under the "Images" tab, click the image thumbnail.
- If you have no custom OPAC pages, go to Tools -> Pages in the staff
  interface anc create one.
  - View the page in the OPAC.
- With "OPACReportProblem" enabled, click the "Report a problem" link at
  the bottom of any OPAC page.
  - Submit a report.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-10-31 23:30:51 UTC
Testing notes (using KTD):

1. OPAC issue notes: enable AllowCheckoutNotes

2. Recalls
   - Enable UseRecalls
   - Set circulation and fine rules:
     . Recalls allowed (total): 10
     . Recalls per record (count): 5
     . On shelf recalls allowed: 5
     . Recall due date interval (day): 5
     . Recall overdue fine amount: 5
     . Recall pickup period (day): 5
   - Check out an item to a patron
   - Place a recall for this item

3. Local images: enable OPACLocalCoverImages and LocalCoverImages, add a cover image to a record
Comment 5 Katrin Fischer 2023-11-01 22:44:46 UTC
Created attachment 158223 [details] [review]
Bug 34855: Use template wrapper for breadcrumbs: OPAC part 3

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

This patch also updates html_helpers.inc to add some logic for handling
the case where the "Home" link is the only breadcrumb (on the OPAC main
page). The change allows for the link to be disabled in this case.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- OPAC main page
- Course reserves
  - Course reserves details
- Libraries
  - Follow the link for a specific library
- View the details of a bibliographic record
- Navigate directly to
  /cgi-bin/koha/opac-downloadshelf.pl?shelfnumber=X where X is the id of
  an existing list. (I don't think this page is ever seen unless the
  user has JavaScript disabled).
- Locate a serial record and click the "More details" link under the
  "Subscriptions" tab.
  - Click the "Full history" tab.
- Log into the OPAC as a user with checkouts. Navigate directly to
  /cgi-bin/koha/opac-issue-note.pl?issue_id=X where X is the id
  (issue_id) of one of the user's checkouts. (Another page which is only
  accessed directly if the user has JS disabled).
- From the logged-in user summary page, click "Change password"
  - Submit a password change.
- With "UseRecalls" enabled, locate a bibliographic record you can place
  a recall request for.
  - Place a recall.
- With "OPACLocalCoverImages" enabled, locate a bibliographic record
  which has a local cover image attached.
  - Under the "Images" tab, click the image thumbnail.
- If you have no custom OPAC pages, go to Tools -> Pages in the staff
  interface anc create one.
  - View the page in the OPAC.
- With "OPACReportProblem" enabled, click the "Report a problem" link at
  the bottom of any OPAC page.
  - Submit a report.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-11-01 22:44:49 UTC
Created attachment 158224 [details] [review]
Bug 34855: (QA follow-up) Terminology: "issue note" to "checkout note"

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-11-03 15:06:08 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-11-10 02:12:42 UTC
Depends on Bug 34849 not in 23.05.x