Bug 35857 - Update display of Clear and Cancel links in the authority search pop-up window
Summary: Update display of Clear and Cancel links in the authority search pop-up window
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on: 34343
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-22 15:53 UTC by Caroline Cyr La Rose
Modified: 2024-05-28 15:45 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 35857: Update authority search pop-up windows with consistent footer markup (4.20 KB, patch)
2024-01-26 18:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35857: Update authority search pop-up windows with consistent footer markup (4.27 KB, patch)
2024-01-26 20:19 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35857: Update authority search pop-up windows with consistent footer markup (4.33 KB, patch)
2024-03-22 10:50 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-01-22 15:53:34 UTC
While documenting bug 31132, I noticed the links in the authority search pop-up window don't look like the other links in Koha. As far as I know, the Cancel links are usually green and become underlined on hover. Here, it is black and not underlined and the Clear form link is blue and becomes green on hover.

To access the pop-up:
1. Go to Cataloging > New record
2. Go to a field that is linked to authorities (for example, in MARC21, 100 or 650)
3. Click the Tag editor button at the end of the $a subfield
Comment 1 Owen Leonard 2024-01-26 18:55:08 UTC
Created attachment 161560 [details] [review]
Bug 35857: Update authority search pop-up windows with consistent footer markup

This patch updates the cataloging authority finder template in order to
style submission and close buttons in a fixed footer at the bottom of
the pop-up window, with markup consistent with other pop-up windows.

Some inline CSS has been removed in favor of styling the "Clear" button
like a default button. Unrelated, "No results found" message has been
wrapped in a "dialog message" div for consistency's sake.

To test, apply the patch and go to Cataloging -> New record.

- In the "Add MARC record" form, locate a tag which is linked to an
  authority type, e.g. 100$a.
- Click the icon to the right of the field to trigger the authority
  search window.
- There should be a fixed footer in the pop-up window with buttons for
  "Submit," "Clear form," and "Close window." Test that each behave
  correctly.
  - The search results view should have the same footer.
  - Clicking "Choose" from the search results should close the window
    and populate the MARC tag with the correct authority data.
Comment 2 Caroline Cyr La Rose 2024-01-26 20:19:22 UTC
Created attachment 161562 [details] [review]
Bug 35857: Update authority search pop-up windows with consistent footer markup

This patch updates the cataloging authority finder template in order to
style submission and close buttons in a fixed footer at the bottom of
the pop-up window, with markup consistent with other pop-up windows.

Some inline CSS has been removed in favor of styling the "Clear" button
like a default button. Unrelated, "No results found" message has been
wrapped in a "dialog message" div for consistency's sake.

To test, apply the patch and go to Cataloging -> New record.

- In the "Add MARC record" form, locate a tag which is linked to an
  authority type, e.g. 100$a.
- Click the icon to the right of the field to trigger the authority
  search window.
- There should be a fixed footer in the pop-up window with buttons for
  "Submit," "Clear form," and "Close window." Test that each behave
  correctly.
  - The search results view should have the same footer.
  - Clicking "Choose" from the search results should close the window
    and populate the MARC tag with the correct authority data.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Kyle M Hall 2024-03-22 10:50:00 UTC
Created attachment 163693 [details] [review]
Bug 35857: Update authority search pop-up windows with consistent footer markup

This patch updates the cataloging authority finder template in order to
style submission and close buttons in a fixed footer at the bottom of
the pop-up window, with markup consistent with other pop-up windows.

Some inline CSS has been removed in favor of styling the "Clear" button
like a default button. Unrelated, "No results found" message has been
wrapped in a "dialog message" div for consistency's sake.

To test, apply the patch and go to Cataloging -> New record.

- In the "Add MARC record" form, locate a tag which is linked to an
  authority type, e.g. 100$a.
- Click the icon to the right of the field to trigger the authority
  search window.
- There should be a fixed footer in the pop-up window with buttons for
  "Submit," "Clear form," and "Close window." Test that each behave
  correctly.
  - The search results view should have the same footer.
  - Clicking "Choose" from the search results should close the window
    and populate the MARC tag with the correct authority data.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-03-22 11:28:32 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-22 14:14:43 UTC
Pushed to 23.11.x for 23.11.06
Comment 6 Lucas Gass 2024-05-28 15:45:02 UTC
Doesn't apply cleanly to 23.05.x, no backport.