While documenting bug 31132, I noticed the links in the authority search pop-up window don't look like the other links in Koha. As far as I know, the Cancel links are usually green and become underlined on hover. Here, it is black and not underlined and the Clear form link is blue and becomes green on hover. To access the pop-up: 1. Go to Cataloging > New record 2. Go to a field that is linked to authorities (for example, in MARC21, 100 or 650) 3. Click the Tag editor button at the end of the $a subfield
Created attachment 161560 [details] [review] Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data.
Created attachment 161562 [details] [review] Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 163693 [details] [review] Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Doesn't apply cleanly to 23.05.x, no backport.