Building on Bug 35877, this patch will update the table settings administration page to use WRAPPERs to generate the Bootstrap accordion markup.
Created attachment 161331 [details] [review] Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table.
The patch no longer applies 8-(... ... Applying: Bug 35883: Use template wrapper for accordions: Table settings administration Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 35883: Use template wrapper for accordions: Table settings administration ...
Created attachment 161763 [details] [review] Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table.
Created attachment 161765 [details] [review] Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 163889 [details] [review] Bug 35883: Use template wrapper for accordions: Table settings administration This patch updates the table settings administration page so that Bootstrap accordion markup is generated by WRAPPERs. This patch also makes some changes to fix the automatic scroll when a table configuration button was clicked. To test, apply the patch and go to Administration -> Table settings. - The list of modules should be displayed as before: Collapsible panels where clicking the module name heading expands the corresponding panel of settings. - Test that direct links to configurable tables still work correctly: - Go to Administration -> Libraries. - Click the "Configure" button at the top of the table of libraries. - You should be taken to the table settings page. - The "Administration" panel should be expanded by default. - You should be scrolled down automatically to the "Libraries" table. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed for 24.05! Well done everyone, thank you!
Enhancement not backported
Code structure change, nothing to add/edit in the manual.