Bug 36592 - Cannot save default display length or default sort order in table settings
Summary: Cannot save default display length or default sort order in table settings
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Pedro Amorim
URL:
Keywords: regression
Depends on: 35883
Blocks: 36096
  Show dependency tree / graph
 
Reported: 2024-04-12 09:43 UTC by Lucas Gass (lukeg)
Modified: 2024-05-23 15:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36592: Fix default display lenght and default sort (2.83 KB, patch)
2024-04-12 12:06 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36592: Fix default display lenght and default sort (2.88 KB, patch)
2024-04-12 13:38 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36592: Fix default display lenght and default sort (2.94 KB, patch)
2024-04-23 11:36 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-04-12 09:43:20 UTC 
To recreate:

1. Go to Admin > Table settings 
2. Find a table that includes Default display length or Default sort order.
3. Try to save a new value.
4. When the page reloads the new values have not been saved.
Comment 1 Lucas Gass (lukeg) 2024-04-12 12:01:43 UTC 
In columns_settings.pl there is this check:

next unless $table_id =~ m|^([^#]*)#(.*)$|;

which checks and passes table_id's named like this:

acq_acqui-home#accounts

but the tables are being like this:

acq_acqui-home_accounts
Comment 2 Lucas Gass (lukeg) 2024-04-12 12:06:35 UTC 
Created attachment 164833 [details] [review]
Bug 36592: Fix default display lenght and default sort

To test:
1. Go to Admin > Table settings
2. Find a table that includes Default display length or Default sort order.
3. Try to save a new value.
4. When the page reloads the new values have not been saved.
5. APPLY PATCH
6. Try 1 -3 again, this time the value should save correctly.
7. Go to Admin > Table settings and make sure the accordians still work and the in page links in each section still work.
Comment 3 Owen Leonard 2024-04-12 13:38:15 UTC 
Created attachment 164849 [details] [review]
Bug 36592: Fix default display lenght and default sort

To test:
1. Go to Admin > Table settings
2. Find a table that includes Default display length or Default sort
   order.
3. Try to save a new value.
4. When the page reloads the new values have not been saved.
5. APPLY PATCH
6. Try 1 -3 again, this time the value should save correctly.
7. Go to Admin > Table settings and make sure the accordians still work
   and the in page links in each section still work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Pedro Amorim 2024-04-23 11:36:18 UTC 
Created attachment 165379 [details] [review]
Bug 36592: Fix default display lenght and default sort

To test:
1. Go to Admin > Table settings
2. Find a table that includes Default display length or Default sort
   order.
3. Try to save a new value.
4. When the page reloads the new values have not been saved.
5. APPLY PATCH
6. Try 1 -3 again, this time the value should save correctly.
7. Go to Admin > Table settings and make sure the accordians still work
   and the in page links in each section still work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-04-26 06:53:52 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-23 15:08:16 UTC 
Depends on Bug 35883 not in 23.11.x