Records added via Acquisition do not contain a 005 tag. This is inconsistent.
Created attachment 161761 [details] [review] Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 161762 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t And via interface: Add a new biblio record via Acquisition. Without this patch it does not have a 005, now it does. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 161776 [details] [review] Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 161777 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 161778 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 161805 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 161992 [details] [review] Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 161993 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 161994 [details] [review] Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 161995 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> > Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thx Phil and Lucas !
Created attachment 165271 [details] [review] Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 165272 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Rebased (Biblio.t)
Created attachment 165370 [details] [review] Bug 35993: Add SimpleMarc::update_last_transaction_time Note: This routine does not check field existence like ModBiblioMarc does/did (see next patch). So it inserts a field 005 if it is not present. Test plan: Run t/SimpleMARC.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 165371 [details] [review] Bug 35993: Apply new routine to ModBiblioMarc Now both AddBiblio and ModBiblio will insert 005 if not present. Test plan: Run t/db_dependent/Biblio.t Add biblio record via acquistion order. Check 005 in the table biblio_metadata. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Clean code, well tested, works as described. Passing QA
Fixed number of tests in Biblio.t (22 -> 23)
Pushed for 24.05! Well done everyone, thank you!
Causes Merge.t to fail. Fix coming
Created attachment 165746 [details] [review] Bug 35993: (follow-up) Fix Merge.t The change for 005 makes some field compares fail. We should exclude 005 in the local compare_fields sub. We do NOT need the compare_fields from AuthoritiesMarc. Removing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Follow-up will be pushed to main.
Created attachment 165748 [details] [review] Bug 35993: (follow-up) Fix MarcOverlayRules.t too Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166063 [details] [review] Bug 35993: (follow-up) Another fix for MarcOverlayRules.t We should not assume comparing within the same second. Now just remove 005 before comparing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Not backported to 23.11.x
I don't think there is anything to add/change in the Koha manual for this.