See also bug 35993. Checking for 005 would not be a good way to approach this question.
Note that acquisition of older books may take a long time. In the meantime we may have changed from creating items at ordering, receiving or cataloging. So we cannot just trust checking items.notforloan.
Bug 24430 added biblio->active_orders but they include the lines which are completely received. These are actually 'not-cancelled' orders.
(In reply to Marcel de Rooy from comment #2) > Bug 24430 added biblio->active_orders but they include the lines which are > completely received. These are actually 'not-cancelled' orders. No this is about current orders. And has been addressed now on 36018.
Created attachment 162334 [details] [review] Bug 35994: Add $biblio->acq_status This allows you to see quickly if a biblio has linked orders or not. And if they are all cancelled, or some still in processing, or some are complete (and the rest cancelled). Test plan: Run t/db_dependent/Koha/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 162335 [details] [review] Bug 35994: Show acq_status on catalogue/detail Test plan: Based on the described criteria, check a few biblio records. Look at Acquisitions tab on the intranet detail page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Issue seems to be resolved on 36018. So back to NSO here. Please try again!
This is a nice addition! I can confirm the "unlinked" and "cancelled" statuses work as intended, as well as the "processing" status when nothing has been received yet. I ran into bug 36628 when trying to set up the cases for "acquired", and the "processing" status when some but not all items have been received, though. :(
Ohhh, the error is coming from the dependency, not master - see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018#c24
Created attachment 165154 [details] [review] Bug 35994: Add $biblio->acq_status This allows you to see quickly if a biblio has linked orders or not. And if they are all cancelled, or some still in processing, or some are complete (and the rest cancelled). Test plan: Run t/db_dependent/Koha/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 165155 [details] [review] Bug 35994: Show acq_status on catalogue/detail Test plan: Based on the described criteria, check a few biblio records. Look at Acquisitions tab on the intranet detail page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Emily Lamancusa from comment #8) > Ohhh, the error is coming from the dependency, not master - see > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018#c24 Fixed
Created attachment 165224 [details] [review] Bug 35994: Add $biblio->acq_status This allows you to see quickly if a biblio has linked orders or not. And if they are all cancelled, or some still in processing, or some are complete (and the rest cancelled). Test plan: Run t/db_dependent/Koha/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 165225 [details] [review] Bug 35994: Show acq_status on catalogue/detail Test plan: Based on the described criteria, check a few biblio records. Look at Acquisitions tab on the intranet detail page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
We're failing a test here I'm afraid.. hopefully it's not to terrible though. Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Biblio.t KO! # Failed test 'Cancelled for only cancelled lines' # at /kohadevbox/koha/t/db_dependent/Koha/Biblio.t line 1003. # got: 'acquired' # expected: 'cancelled' # Looks like you failed 1 test of 9. # Failed test '->orders, ->uncancelled_orders and ->acq_status tests' # at /kohadevbox/koha/t/db_dependent/Koha/Biblio.t line 1006. # Looks like you failed 1 test of 37. /kohadevbox/koha/t/db_dependent/Koha/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/37 subtests
Created attachment 166510 [details] [review] Bug 35994: (QA follow-up) Fix Biblio.t A follow-up changed orders->cancel a bit. This test assumed to cancel completed lines here. So we are doing it now with a direct update to have the original result. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thanks for the testing Emily. You've highlighted a fun little challenge with the translated notices which I'm working on now.
Created attachment 166537 [details] [review] Bug 35994: Add $biblio->acq_status This allows you to see quickly if a biblio has linked orders or not. And if they are all cancelled, or some still in processing, or some are complete (and the rest cancelled). Test plan: Run t/db_dependent/Koha/Biblio.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 166538 [details] [review] Bug 35994: Show acq_status on catalogue/detail Test plan: Based on the described criteria, check a few biblio records. Look at Acquisitions tab on the intranet detail page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 166539 [details] [review] Bug 35994: (QA follow-up) Fix Biblio.t A follow-up changed orders->cancel a bit. This test assumed to cancel completed lines here. So we are doing it now with a direct update to have the original result. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the quick follow-up. All looking good now, working as expected, no regressions found. Passing QA
I am no sure about displaying the status for records with no orders. I have tweaked the HTML a little in hope to make it easier to translate, but also added a class that might help with customizations.
TT variable name "myvar"?
Pushed for 24.05! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #22) > TT variable name "myvar"? Yeah that wasnt the best name..
Hi Marcel, we have a failure here that might or might not be related to this work, could you have a look please? t_db_dependent_api_v1_acquisitions_orders_t
(In reply to Katrin Fischer from comment #25) > Hi Marcel, we have a failure here that might or might not be related to this > work, could you have a look please? > t_db_dependent_api_v1_acquisitions_orders_t Jonathan posted a fix on the dependency (36018)
Not backported to 23.11.x
This seems like a backend architecture change, it doesn't affect the manual.