Bug 36864 - Further improvements to holds request page
Summary: Further improvements to holds request page
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 30579
Blocks: 36899
  Show dependency tree / graph
 
Reported: 2024-05-14 21:06 UTC by Lucas Gass (lukeg)
Modified: 2024-07-25 11:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This is part of improvements to placing holds from the record page in the staff interface. It adds a tick icon with a green background to the section selected (either 'Hold next available item' or 'Hold a specific item'). It prevents selecting drop down lists in the section not selected.
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36864: Add classes/CSS/fix markup on request.tt (8.19 KB, patch)
2024-05-14 21:13 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36864: Add a font awesome icon to indicate enabled (1.18 KB, patch)
2024-05-14 21:47 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36864: Add classes/CSS/fix markup on request.tt (8.25 KB, patch)
2024-05-15 11:01 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36864: Add a font awesome icon to indicate enabled (1.22 KB, patch)
2024-05-15 11:02 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36864: Add classes/CSS/fix markup on request.tt (8.31 KB, patch)
2024-05-15 13:51 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 36864: Add a font awesome icon to indicate enabled (1.29 KB, patch)
2024-05-15 13:51 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-05-14 21:06:04 UTC 
Bug 30579 did some things to make the hold request page easier to navigate. Great improvements. There was a couple small things I'd like to address:

1. You can click on the disabled fieldset select2 dropdowns.
2. Invalid HTML. Inputs cannot be children of an HTML button.
Comment 1 Lucas Gass (lukeg) 2024-05-14 21:13:16 UTC 
Created attachment 166743 [details] [review]
Bug 36864: Add classes/CSS/fix markup on request.tt

To test:
1. APPLY PATCH
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Place a hold
4. On reserve/request.pl the 'Hold a specific item' fieldset should be disabled by default.
5. While disabled try clicking on the Allowed pickup locations dropdowns, you should not be able to.
6. In the 'Hold next available item', while enabled, you should be able to interact with the dropdowns.
7. Use the radio buttons to enable the 'Hold a specific item' fieldset. You should now be able to interact with the dropdowns.
Comment 2 Lucas Gass (lukeg) 2024-05-14 21:47:36 UTC 
Created attachment 166744 [details] [review]
Bug 36864: Add a font awesome icon to indicate enabled
Comment 3 Owen Leonard 2024-05-15 11:01:58 UTC 
Created attachment 166768 [details] [review]
Bug 36864: Add classes/CSS/fix markup on request.tt

To test:
1. APPLY PATCH
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Place a hold
4. On reserve/request.pl the 'Hold a specific item' fieldset should be
   disabled by default.
5. While disabled try clicking on the Allowed pickup locations
   dropdowns, you should not be able to.
6. In the 'Hold next available item', while enabled, you should be able
   to interact with the dropdowns.
7. Use the radio buttons to enable the 'Hold a specific item' fieldset.
   You should now be able to interact with the dropdowns.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2024-05-15 11:02:01 UTC 
Created attachment 166769 [details] [review]
Bug 36864: Add a font awesome icon to indicate enabled

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2024-05-15 11:02:22 UTC 
Very nice!
Comment 6 Katrin Fischer 2024-05-15 12:17:54 UTC 
Can we make the bug description a bit more descriptive please? :)
Comment 7 Martin Renvoize (ashimema) 2024-05-15 13:51:14 UTC 
Created attachment 166778 [details] [review]
Bug 36864: Add classes/CSS/fix markup on request.tt

To test:
1. APPLY PATCH
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Place a hold
4. On reserve/request.pl the 'Hold a specific item' fieldset should be
   disabled by default.
5. While disabled try clicking on the Allowed pickup locations
   dropdowns, you should not be able to.
6. In the 'Hold next available item', while enabled, you should be able
   to interact with the dropdowns.
7. Use the radio buttons to enable the 'Hold a specific item' fieldset.
   You should now be able to interact with the dropdowns.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize (ashimema) 2024-05-15 13:51:17 UTC 
Created attachment 166779 [details] [review]
Bug 36864: Add a font awesome icon to indicate enabled

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize (ashimema) 2024-05-15 13:53:31 UTC 
Nice improvement, works as designed.

Passing QA
Comment 10 Katrin Fischer 2024-05-17 08:07:40 UTC 
I think it's a visual improvement, but I feel people will still think they need to click into the rather small radio boxes instead of clicking on the label that is a much nicer click target. I wish we could improve on that in another bug maybe.
Comment 11 Katrin Fischer 2024-05-17 08:37:59 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 12 Lucas Gass (lukeg) 2024-05-20 15:58:48 UTC 
(In reply to Katrin Fischer from comment #10)
> I think it's a visual improvement, but I feel people will still think they
> need to click into the rather small radio boxes instead of clicking on the
> label that is a much nicer click target. I wish we could improve on that in
> another bug maybe.

I agree. So I filed Bug 36899:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36899
Comment 13 Fridolin Somers 2024-05-29 13:09:33 UTC 
Depends on Bug 30579 not in 23.11.x