Bug 36899 - Further improvements to holds request page, part 2
Summary: Further improvements to holds request page, part 2
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 36864 30579
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-20 15:47 UTC by Lucas Gass (lukeg)
Modified: 2024-07-25 11:15 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This is part of improvements to placing holds from the record page in the staff interface. When selecting 'Hold next available item', 'Hold next available item from an item group' (when item groups enabled), or 'Hold a specific item' you can now select anywhere on that section of the page, instead of having to select the radio button beside each heading.
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36899: Make entire fieldset clickable (3.34 KB, patch)
2024-05-20 15:58 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36899: (follow-up) Prevent disabling when clicking twice (1.14 KB, patch)
2024-05-20 16:23 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36899: Make entire fieldset clickable (3.39 KB, patch)
2024-05-20 19:28 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36899: (follow-up) Prevent disabling when clicking twice (1.19 KB, patch)
2024-05-20 19:28 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36899: Account for item groups (4.04 KB, patch)
2024-05-20 22:06 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36899: Make entire fieldset clickable (3.46 KB, patch)
2024-05-21 13:14 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 36899: (follow-up) Prevent disabling when clicking twice (1.25 KB, patch)
2024-05-21 13:14 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 36899: Account for item groups (4.11 KB, patch)
2024-05-21 13:14 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-05-20 15:47:40 UTC 
Based on a comment in Bug 36854:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864#c10

The entire fieldset should be clickable, not just the radio button.
Comment 1 Lucas Gass (lukeg) 2024-05-20 15:58:13 UTC 
Created attachment 166938 [details] [review]
Bug 36899: Make entire fieldset clickable

To test:
1. APPLY PATCH
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Follow the test plan from bug 36864
4. Now the entire disabled fieldset should be clickable.
5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled.
Comment 2 Lucas Gass (lukeg) 2024-05-20 16:23:41 UTC 
Created attachment 166939 [details] [review]
Bug 36899: (follow-up) Prevent disabling when clicking twice
Comment 3 David Nind 2024-05-20 19:28:40 UTC 
Created attachment 166944 [details] [review]
Bug 36899: Make entire fieldset clickable

To test:
1. APPLY PATCH
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Follow the test plan from bug 36864
4. Now the entire disabled fieldset should be clickable.
5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-05-20 19:28:42 UTC 
Created attachment 166945 [details] [review]
Bug 36899: (follow-up) Prevent disabling when clicking twice

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-05-20 19:33:49 UTC 
Nice! This makes it so much nicer and easier to use.
Comment 6 David Nind 2024-05-20 21:02:18 UTC 
I've signed this off, but then discovered that this needs a follow-up for item groups ("Hold next available item from an item group"):

- The fieldset heading has a border around it
- You still need to click on the radio button/heading to select this option, rather than anywhere in this section of the page

Enabling item groups and holds:
1. Enable the EnableItemGroups and EnableItemGroupHolds system preferences
2. Create item groups and add items to the groups:
   - find a record with multiple items
   - in the normal view > holdings table, select the 'Items group' tab
   - create two item groups (+ New item group)
   - from the holdings table, add items to the groups (select the tick box for an item, then options to 'Add/move to item group' and 'Remove from item group' appear)
3. Result: When placing a hold, there should be a new section "Hold next available item from an item group".
Comment 7 Lucas Gass (lukeg) 2024-05-20 22:06:15 UTC 
Created attachment 166946 [details] [review]
Bug 36899: Account for item groups
Comment 8 Lucas Gass (lukeg) 2024-05-20 22:07:03 UTC 
(In reply to David Nind from comment #6)
> I've signed this off, but then discovered that this needs a follow-up for
> item groups ("Hold next available item from an item group"):
> 
> - The fieldset heading has a border around it
> - You still need to click on the radio button/heading to select this option,
> rather than anywhere in this section of the page
> 
> Enabling item groups and holds:
> 1. Enable the EnableItemGroups and EnableItemGroupHolds system preferences
> 2. Create item groups and add items to the groups:
>    - find a record with multiple items
>    - in the normal view > holdings table, select the 'Items group' tab
>    - create two item groups (+ New item group)
>    - from the holdings table, add items to the groups (select the tick box
> for an item, then options to 'Add/move to item group' and 'Remove from item
> group' appear)
> 3. Result: When placing a hold, there should be a new section "Hold next
> available item from an item group".

Thanks David! I have provided a follow-up for item groups.
Comment 9 David Nind 2024-05-20 22:26:27 UTC 
(In reply to Lucas Gass from comment #8)

> Thanks David! I have provided a follow-up for item groups.

Thanks Lucas! Can confirm that this all works as expected.
Comment 10 Martin Renvoize (ashimema) 2024-05-21 13:14:54 UTC 
Created attachment 166971 [details] [review]
Bug 36899: Make entire fieldset clickable

To test:
1. APPLY PATCH
2. Regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface )
3. Follow the test plan from bug 36864
4. Now the entire disabled fieldset should be clickable.
5. When the disabled fieldset is clicked from anywhere with it the fieldset should become enabled. The other one should then be disabled.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 11 Martin Renvoize (ashimema) 2024-05-21 13:14:57 UTC 
Created attachment 166972 [details] [review]
Bug 36899: (follow-up) Prevent disabling when clicking twice

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 12 Martin Renvoize (ashimema) 2024-05-21 13:14:59 UTC 
Created attachment 166973 [details] [review]
Bug 36899: Account for item groups

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 13 Katrin Fischer 2024-05-22 14:20:19 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 14 Fridolin Somers 2024-05-29 14:11:52 UTC 
Depends on Bug 36864 not in 23.11.x