Bug 4069 - organize filter on suggestions doesn't work
Summary: organize filter on suggestions doesn't work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: PC All
: P5 - low critical (vote)
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 05:24 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
no name tabs (28.69 KB, image/png)
2010-06-25 13:34 UTC, Nicole C. Engard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:22:48 UTC


---- Reported by nengard@gmail.com 2010-01-27 17:24:32 ----

When you change the 'organize by' pull down menu to anything other than 'no tabs' or 'status' you get nothing.  What is the purpose of this menu.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:22 UTC  ---

This bug was previously known as _bug_ 4069 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4069

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Owen Leonard 2010-06-24 19:05:43 UTC
Here is what I see:

1. "No tabs." What is that supposed to do? Choosing this gives me tabs for "Accepted," "Pending," and "Checked." I assume that means it isn't working.

2. "Status." Same as #1, which I assume is correct in this case.

3. "Library." Interface displays a separate tab for each library for which suggestions have been made (based on the suggester's home library). Working.

4. "Item type." No effect. Makes sense: when submitting a suggestion the item type is not saved to the database (Bug 4830).

5. "Sort1." No effect. I don't even see a place in the OPAC or staff client where one could add sort1 data to the table, although the columns are there.

6. "Managed by." Interface displays a separate tab for "Owen Leonard" and "No name," which seems to be technically correct (the "no name" items are new pending suggestions."

7. "Accepted by." Interface displays two tabs, both labeled "No name." Both tabs are identical, containing all items (not just accepted ones).

Wrap-up: The only functioning "organize" options are "Status," "Library," and "Managed by." The others should be hidden if they can't be fixed in time for the next release.
Comment 2 Owen Leonard 2010-06-24 19:28:45 UTC
> 4. "Item type." No effect. Makes sense: when submitting a suggestion the item
> type is not saved to the database (Bug 4830).

Correction: Working properly. Bug 4830 seems to prevent values from being saved if the form display collection codes. If you have the AdvancedSearchTypes system preference set to 'itemtype' values are stored correctly and this filter works.
Comment 3 Owen Leonard 2010-06-25 13:19:29 UTC
This commit addresses most of the issues in this bug report:

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=b592c3a0f51625da35a37b8334a04eaad6f25549

Still unfixed is the issue with the "Accepted by" option.
Comment 4 Nicole C. Engard 2010-06-25 13:34:10 UTC
Created attachment 2269 [details]
no name tabs

The organize by filter updates brings in a new bug.  When you change the organize option the tabs read 'no name' see the attached image.
Comment 5 Nicole C. Engard 2010-06-25 13:36:15 UTC
The past attachment was for 'item type' but the pull down on the left doesn't update when you choose to organize differently.  The pull down needs to update and if there is no 'name' or in this case 'item type' it should say 'no item type' and should all be on one tab - not 2 tabs both with the same label.
Comment 6 Owen Leonard 2010-06-25 13:54:14 UTC
(In reply to comment #5)
> The past attachment was for 'item type' but the pull down on the left doesn't
> update when you choose to organize differently.

I filed a separate bug report for this, Bug 4907.

> and if there is no 'name' or in this case 'item type' it should say 'no item
> type' and should all be on one tab - not 2 tabs both with the same label.

I agree that "no name" isn't desirable but to be precise the problem was not introduced in the latest update.
Comment 7 Katrin Fischer 2011-10-29 13:22:11 UTC
The 'organize by' filters work nicely now. The only problem I spotted is bug 4907.