Bug 4830 - item type on purchase suggestion not carried over
Summary: item type on purchase suggestion not carried over
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-27 14:59 UTC by Nicole C. Engard
Modified: 2012-10-25 23:10 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
item type showing on the manage suggestions page (25.95 KB, image/png)
2010-05-27 14:59 UTC, Nicole C. Engard
Details
changed to the first alpha item type when editing (37.99 KB, image/png)
2010-05-27 15:00 UTC, Nicole C. Engard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-05-27 14:59:53 UTC
Created attachment 2178 [details]
item type showing on the manage suggestions page

When editing a suggestion the item type that the patron picked isn't displayed.  The patron can choose an item type from the OPAC, but it doesn't actually record that anywhere - or if it does it doesn't display to the staff.
Comment 1 Nicole C. Engard 2010-05-27 15:00:21 UTC
Created attachment 2179 [details]
changed to the first alpha item type when editing
Comment 2 Katrin Fischer 2011-10-29 12:42:59 UTC
I tested on current master and the item type saves correctly now.

1) Made suggestion in OPAC, set itemtype to 'mixed materials'
2) Checked suggestions in staff, item type code was shown in list of pending suggestions
3) Checked organising by item type worked
4) Edited suggestion, correct item type was selected

Please reopen if I missed something.
Comment 3 Katrin Fischer 2011-10-29 12:52:00 UTC
Owen Leonard noted on bug 4069:
Bug 4830 seems to prevent values from being saved
if the form display collection codes. If you have the AdvancedSearchTypes
system preference set to 'itemtype' values are stored correctly and this filter
works.

I tested this too and it works now. 

- The collection code is saved into the itemtype column in suggestions. 
- The suggestion list shows the correct collection code.
- When you open the suggestion for editing, the correct pull down list for collections is shown.