Bug 5583 - Rename variable to reflect what it is
Summary: Rename variable to reflect what it is
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-06 11:30 UTC by Colin Campbell
Modified: 2012-10-25 23:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (2.36 KB, patch)
2011-01-06 11:54 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2011-01-06 11:30:30 UTC
When checking any UNIMARC implications of bug 5582 encountered the opaque variable name fieldnumber. It does not refer to a field but the ISBD block (an organizing principle of UNIMARC) Change variable name to reflect what it is/does. Clarity is a virtue if you have to maintain the code.
Comment 1 Colin Campbell 2011-01-06 11:54:25 UTC
Created attachment 2953 [details] [review]
Proposed Patch
Comment 2 Chris Cormack 2011-01-06 20:46:44 UTC
Pushed, please test
Comment 3 MJ Ray (software.coop) 2011-02-02 08:52:31 UTC
This bug is mentioned in:
Bug 5583 Rename fieldnumber to blocknumber http://lists.koha-community.org/pipermail/koha-patches/2011-January/013531.html