Currently the build-git-snapshot script has a lot of stuff hardcoded into it. In order to do custom packages, it's easier to let this be controlled by command-line arguments.
Created attachment 4007 [details] [review] patch
Created attachment 4338 [details] [review] Updates to account for new version number
Created attachment 4391 [details] [review] Signed off Patch
Created attachment 4392 [details] [review] Signed off follow up Patch
QA comment I don't set "passed QA", not because i've detected a problem, but because i'm unable to say anything about this patch from a QA point of view. I just can say it will be harmless to any Koha install, as it contains nothing related to Koha, it's related to Debian packaging So letting Ian the final cut about that. It's signed-off by chris, I would tend to think it's OK, but can't be sure.
Not even just related to packaging, it only affects people who would be creating their own packages. For what it's worth, we've been using it in production for a while now.
I have also used this script successfully.
Good enough for me, im pushing it.
Created attachment 5370 [details] [review] Bug 5602 - [3.4.x] Rewrite of package building script Note: this is pulling in the most recent version from master. Working with two different versions that have two different options was getting painful, and it doesn't touch anything outside of debian/
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.