Bug 6722 - build-git-snapshot output doesn't show up on the screen
Summary: build-git-snapshot output doesn't show up on the screen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Robin Sheat
QA Contact: Bugs List
URL:
Keywords:
Depends on: 5602
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-15 05:17 UTC by Robin Sheat
Modified: 2012-10-25 23:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 6722: Cause build output to appear on the screen (1.34 KB, patch)
2011-08-15 05:19 UTC, Robin Sheat
Details | Diff | Splinter Review
Signed-off patch (1.40 KB, patch)
2011-08-15 09:58 UTC, Magnus Enger
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2011-08-15 05:17:20 UTC
The way the Perl version of build-git-snapshot works, it doesn't output the build process as its going.

This makes it harder to see what's happening, or why it broke.
Comment 1 Robin Sheat 2011-08-15 05:19:37 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2011-08-15 09:29:49 UTC
Great patch! But it does produce a lot of output, could it be an idea to "hide" it behind a --verbose or --debug option?
Comment 3 Magnus Enger 2011-08-15 09:58:30 UTC
Created attachment 5017 [details] [review]
Signed-off patch

As Robin said, this makes debugging the building of packages much easier. Signing off!
Comment 4 Robin Sheat 2011-08-15 11:59:11 UTC
I don't want to hide it because if you're building packages, this is the kind of thing you should be seeing. Also, it beats waiting for 5 minutes with no output. As this is a developer tool, I think it's OK to show all the build output.
Comment 5 Magnus Enger 2011-09-02 11:47:51 UTC
Hm, seems I forgot to change the Patch Status when I looked at this in the middle of August... And I agree with Robin now, all that output shouldn't hurt.
Comment 6 Chris Cormack 2011-09-04 08:15:48 UTC
Debian packaging patch, pushed please test
Comment 7 Robin Sheat 2011-10-26 21:54:46 UTC
This fix was pulled into 3.4.x via bug 5602.