Bug 5622 - Improve display of MARC21 773 field in XSLT detail view
Summary: Improve display of MARC21 773 field in XSLT detail view
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5662 5663
  Show dependency treegraph
 
Reported: 2011-01-17 13:29 UTC by Marcel de Rooy
Modified: 2012-10-25 23:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (2.27 KB, patch)
2011-01-17 13:52 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Revised patch (5.66 KB, patch)
2011-01-27 13:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Revised patch (7.82 KB, patch)
2011-02-02 15:54 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Signed-off patch (7.90 KB, patch)
2011-03-17 14:24 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2011-01-17 13:29:05 UTC
Currently, the 773 is only shown in staff normal view via XSLT bloc if leader19==c. The label is named: 'Set'.
This is too limited.
I would suggest to remove the limitation of checking leader19 and renaming the label to the more general 'In:'.
This is in accordance with Library of Congress MARC standard.

I will send a patch.
Comment 1 Marcel de Rooy 2011-01-17 13:52:41 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2011-01-27 13:38:36 UTC
Sending a revised patch for showing the correct control number in the URL.
According to LOC guidelines, the control number in $w may be prefixed by an organization code between parentheses like (NL-AmRIJ)12345. The URL should only list the record number 12345.

This patch only corrects that for the 773 field. I will send another followup patch for other MARC tags (with a generic bug report). The common XSLT code for that is included in this patch ALREADY. So the followup will be depending on this one.
Comment 3 Marcel de Rooy 2011-01-27 13:40:37 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2011-01-31 14:38:49 UTC
Resetting patch status. Found a bug in this patch; will submit a corrected version.
Comment 5 Marcel de Rooy 2011-02-02 13:29:03 UTC
Comment on attachment 3029 [details] [review]
Revised patch

Erroneous
Comment 6 Marcel de Rooy 2011-02-02 15:51:19 UTC
Initial description was not completely valid. Field 773 was shown already under several conditions.
Latest patch extends display with the following:

Applies change to OPAC and staff detail view.
Chops punctuation. Adds 773g (including page numbers or so). Strips MARC org code from URL.
Utils code is used as basis for patches #5662 and #5663 too.
Comment 7 Marcel de Rooy 2011-02-02 15:54:12 UTC
Created attachment 3052 [details] [review]
Revised patch
Comment 8 MJ Ray (software.coop) 2011-02-04 09:14:18 UTC
This bug is mentioned in:
Bug 5622 (Show 773 host in staff normal view) http://lists.koha-community.org/pipermail/koha-patches/2011-January/013614.html
Bug 5622: Always show host entry (773) in staff; control number without organization code http://lists.koha-community.org/pipermail/koha-patches/2011-January/013710.html
Comment 9 Jared Camins-Esakov 2011-03-17 14:24:48 UTC
Created attachment 3342 [details] [review]
Signed-off patch
Comment 10 Marcel de Rooy 2011-03-17 14:29:01 UTC
(In reply to comment #9)
> Created attachment 3342 [details] [review]
> Signed-off patch

Thanks!
Comment 11 Chris Cormack 2011-03-17 22:20:19 UTC
Pushed, please test
Comment 12 Marcel de Rooy 2011-03-18 13:35:38 UTC
Works for me. 
When testing, add a zero in the first 773 indicator to display the note. If you enter something like (ABCdef77)456 in the control number, the link should correctly point to record 456, stripping off the stuff between parentheses.