desc foloows
According to LOC guidelines, the control number in $w may be prefixed by an organization code between parentheses like (NL-AmRIJ)12345. The URL should only list the record number 12345. (Currently, the complete field is copied into the URL and therefore it is not working.) Revised patch 5622 corrected this for the host entry (773) in staff client and included generic XSLT code to resolve the problem. This followup patch will build upon the generic code in the Utils.xsl and include calls to that routine for other fields at the staff side. See bug 5662 for OPAC side.
Created attachment 4627 [details] [review] Patch
TEST PLAN: Enable the pref UseControlNumber when testing this patch. And set pref XSLTDetailsDisplay to using XSLT stylesheets. Test by adding a control number ($w) in abovementioned fields. Go to staff detail and check if the links work. Add some orgcode between parentheses or brackets in front of the control number. Test again in staff detail if the links still work.
Hi Marcel, wondered why it didn't work - now I see this is also the file for OPAC not for intranet. Can you attach the right patch please?
Created attachment 4651 [details] [review] Patch Attached the wrong file; correcting it now. Thanks, Katrin.
Created attachment 4965 [details] [review] [SIGNED-OFF] 5663: Show control number without organization code in staff URLs Intranet detail xsl adjusted at 4 places: 773 when leader19=c, 775, 780, 785. Enable the pref UseControlNumber when testing this patch. And set pref XSLTDetailsDisplay to using XSLT stylesheets. Test by adding a control number ($w) in abovementioned fields. Go to staff detail and check if the links work. Add some orgcode between parentheses or brackets in front of the control number. Test again in staff detail if the links still work. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
(In reply to comment #6) > Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Thanks for signing this patch too!
XSL only change, from <xsl:value-of> to <xsl:call-template> with <xsl:with-param> values. Uses existing and known MARC21slimUtils template. Marking as Passed QA.
Pushed, please test
Closing it myself; runs in production with us for months.