Bug 6855 - bullet point showing in wrong place on error message
Summary: bullet point showing in wrong place on error message
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: cgi-bin/koha/reserve/request.pl?bibli...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-08 00:04 UTC by Nicole C. Engard
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
chrome error message (25.52 KB, image/png)
2011-09-08 00:04 UTC, Nicole C. Engard
Details
firefox error message (27.64 KB, image/png)
2011-09-08 00:04 UTC, Nicole C. Engard
Details
Proposed fix (964 bytes, patch)
2011-09-12 19:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot of multiline message (20.15 KB, image/png)
2011-09-20 12:47 UTC, Owen Leonard
Details
still funny in chrome on mac (29.34 KB, image/png)
2011-09-27 16:47 UTC, Nicole C. Engard
Details
Fix for Bug 6855 - List bullet showing in wrong place on error message (1.20 KB, patch)
2012-06-10 03:16 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Error message on Chrome for Mac after patch (13.17 KB, image/png)
2012-06-10 03:18 UTC, Jared Camins-Esakov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-09-08 00:04:30 UTC
Created attachment 5345 [details]
chrome error message

See attached.  When placing a hold in Chrome the bullet point shows to the far left bottom of the box instead of next to the text like it does in Firefox.
Comment 1 Nicole C. Engard 2011-09-08 00:04:53 UTC
Created attachment 5346 [details]
firefox error message

bullet in right place
Comment 2 Owen Leonard 2011-09-12 19:55:20 UTC Comment hidden (obsolete)
Comment 3 Frédéric Demians 2011-09-20 05:36:07 UTC
> Adding some more specific CSS to help Webkit browsers display the list bullets
> correctly.

Yes, but what will happen with a muli-lines error message? The text will be aligned to the bullet, no more indentation.
Comment 4 Owen Leonard 2011-09-20 12:47:21 UTC
Created attachment 5474 [details]
Screenshot of multiline message

(In reply to comment #3)
> Yes, but what will happen with a muli-lines error message? The text will be
> aligned to the bullet, no more indentation.

This patch doesn't change the way error messages are displayed in general, it simply makes the display WebKit browsers match how it is displayed in Firefox. This attachment shows how it would look with a multi-line error message in Chrome, with the patch applied. It should match how it would look in Firefox with or without the patch applied.
Comment 5 Nicole C. Engard 2011-09-27 16:47:45 UTC
Created attachment 5615 [details]
still funny in chrome on mac

after applying the patch it looks fine on firefox on mac, but not on chrome on mac.
Comment 6 Jared Camins-Esakov 2012-06-10 03:16:28 UTC
Created attachment 10060 [details] [review]
Fix for Bug 6855 - List bullet showing in wrong place on error message

Added some more specific CSS to help Webkit browsers display
the lists bullets correctly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 9 June 2012. Signing off as well, since the rebase and test
were trivial.
Comment 7 Jared Camins-Esakov 2012-06-10 03:18:25 UTC
Created attachment 10061 [details]
Error message on Chrome for Mac after patch
Comment 8 Paul Poulain 2012-06-10 12:03:21 UTC
QA comment: tiny patch css only, passed QA

Note that it seems that the patch also changes the dialog windows look without announcing the change:
+div.dialog {
+  background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< HERE
+  text-align : center;
+}

A small change, not worth complaining, just pointing that
Comment 9 Owen Leonard 2012-06-10 12:44:28 UTC
(In reply to comment #8)
> +div.dialog {
> +  background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<<
> HERE
> +  text-align : center;
> +}

This is a regression of Bug 6865
Comment 10 Paul Poulain 2012-06-10 12:50:03 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > +div.dialog {
> > +  background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<<
> > HERE
> > +  text-align : center;
> > +}
> 
> This is a regression of Bug 6865

Owen, I'm not sure I get what you mean here = this div.dialog is a regression and should be discarded ? Should I revert the patch and ask for one that is dealing with .ialog li only ?
Comment 11 Owen Leonard 2012-06-10 12:54:56 UTC
(In reply to comment #10)

> > > +  background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<<

> > This is a regression of Bug 6865
> 
> Owen, I'm not sure I get what you mean here = this div.dialog is a
> regression and should be discarded ?

If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then it is a regression of Bug 6865 which removed all such calls to background gradient images. It's not a big deal, but it requires a follow-up to correct it.
Comment 12 Chris Cormack 2012-06-14 06:48:26 UTC
Waiting until the follow up is added, before I push this to 3.8.x
Comment 13 Paul Poulain 2012-06-14 13:20:23 UTC
(In reply to comment #11)

> If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then
> it is a regression of Bug 6865 which removed all such calls to background
> gradient images. It's not a big deal, but it requires a follow-up to correct
> it.

As you're the author of the patch, I suppose you plan to write the follow-up? Please confirm, (or I can revert this patch if you prefer)
Comment 14 Chris Cormack 2012-07-18 07:56:24 UTC
Pushed in conjunction with bug 8398 which undoes the regression this patch adds