Created attachment 5345 [details] chrome error message See attached. When placing a hold in Chrome the bullet point shows to the far left bottom of the box instead of next to the text like it does in Firefox.
Created attachment 5346 [details] firefox error message bullet in right place
Created attachment 5408 [details] [review] Proposed fix Adding some more specific CSS to help Webkit browsers display the list bullets correctly.
> Adding some more specific CSS to help Webkit browsers display the list bullets > correctly. Yes, but what will happen with a muli-lines error message? The text will be aligned to the bullet, no more indentation.
Created attachment 5474 [details] Screenshot of multiline message (In reply to comment #3) > Yes, but what will happen with a muli-lines error message? The text will be > aligned to the bullet, no more indentation. This patch doesn't change the way error messages are displayed in general, it simply makes the display WebKit browsers match how it is displayed in Firefox. This attachment shows how it would look with a multi-line error message in Chrome, with the patch applied. It should match how it would look in Firefox with or without the patch applied.
Created attachment 5615 [details] still funny in chrome on mac after applying the patch it looks fine on firefox on mac, but not on chrome on mac.
Created attachment 10060 [details] [review] Fix for Bug 6855 - List bullet showing in wrong place on error message Added some more specific CSS to help Webkit browsers display the lists bullets correctly. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased 9 June 2012. Signing off as well, since the rebase and test were trivial.
Created attachment 10061 [details] Error message on Chrome for Mac after patch
QA comment: tiny patch css only, passed QA Note that it seems that the patch also changes the dialog windows look without announcing the change: +div.dialog { + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< HERE + text-align : center; +} A small change, not worth complaining, just pointing that
(In reply to comment #8) > +div.dialog { > + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< > HERE > + text-align : center; > +} This is a regression of Bug 6865
(In reply to comment #9) > (In reply to comment #8) > > +div.dialog { > > + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< > > HERE > > + text-align : center; > > +} > > This is a regression of Bug 6865 Owen, I'm not sure I get what you mean here = this div.dialog is a regression and should be discarded ? Should I revert the patch and ask for one that is dealing with .ialog li only ?
(In reply to comment #10) > > > + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< > > This is a regression of Bug 6865 > > Owen, I'm not sure I get what you mean here = this div.dialog is a > regression and should be discarded ? If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then it is a regression of Bug 6865 which removed all such calls to background gradient images. It's not a big deal, but it requires a follow-up to correct it.
Waiting until the follow up is added, before I push this to 3.8.x
(In reply to comment #11) > If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then > it is a regression of Bug 6865 which removed all such calls to background > gradient images. It's not a big deal, but it requires a follow-up to correct > it. As you're the author of the patch, I suppose you plan to write the follow-up? Please confirm, (or I can revert this patch if you prefer)
Pushed in conjunction with bug 8398 which undoes the regression this patch adds