Bug 8398 - Missing image file in staff global css
Summary: Missing image file in staff global css
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-09 19:29 UTC by Katrin Fischer
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8398 - Missing image file in staff global css (1.38 KB, patch)
2012-07-09 19:52 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8398 - Missing image file in staff global css (1.55 KB, patch)
2012-07-09 20:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-07-09 19:29:25 UTC
While testing the duplicate authority message I noticed this error in the staff logs:

[Mon Jul 09 08:16:36 2012] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/img/dialog-bg.gif, referer: http://localhost:8080/intranet-tmpl/prog/en/css/staff-global.css
[Mon Jul 09 08:16:45 2012] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/img/dialog-bg.gif, referer: http://localhost:8080/intranet-tmpl/prog/en/css/staff-global.css
Comment 1 Owen Leonard 2012-07-09 19:52:22 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-07-09 20:07:17 UTC
Created attachment 10730 [details] [review]
[SIGNED-OFF] Bug 8398 - Missing image file in staff global css

This patch fixes a regression introduced by the fix for
Bug 6855 (bullet point showing in wrong place on error message)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855

The patch removes the re-introduced reference to a
background image which has since been removed. Testers should
check that this patch does not re-introduce Bug 6855.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I checked the styling of the error messages in Chromium and Firefox.
The logs are no longer complaining about the missing image.
Looks good to me.
Comment 3 Mason James 2012-07-17 04:37:52 UTC
passing QA...

trivial patch, passes QA tests

mason@xen1:~/g/head$ koha-qa.pl
10b9097 Bug 8398 - Missing image file in staff global css
- starting perlcritic-progressive tests... OK
- starting perl -c syntax tests... OK
- starting xt/tt_valid.t tests... OK
- starting xt/author/vaild-template.t tests... OK
Comment 4 Paul Poulain 2012-07-17 13:23:01 UTC
I think this should go to 3.8, but not sure
Comment 5 Chris Cormack 2012-07-18 07:57:48 UTC
Pushed to 3.8.x will be in 3.8.3