While testing the duplicate authority message I noticed this error in the staff logs: [Mon Jul 09 08:16:36 2012] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/img/dialog-bg.gif, referer: http://localhost:8080/intranet-tmpl/prog/en/css/staff-global.css [Mon Jul 09 08:16:45 2012] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/img/dialog-bg.gif, referer: http://localhost:8080/intranet-tmpl/prog/en/css/staff-global.css
Created attachment 10729 [details] [review] Bug 8398 - Missing image file in staff global css This patch fixes a regression introduced by the fix for Bug 6855 (bullet point showing in wrong place on error message) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 The patch removes the re-introduced reference to a background image which has since been removed. Testers should check that this patch does not re-introduce Bug 6855.
Created attachment 10730 [details] [review] [SIGNED-OFF] Bug 8398 - Missing image file in staff global css This patch fixes a regression introduced by the fix for Bug 6855 (bullet point showing in wrong place on error message) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 The patch removes the re-introduced reference to a background image which has since been removed. Testers should check that this patch does not re-introduce Bug 6855. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I checked the styling of the error messages in Chromium and Firefox. The logs are no longer complaining about the missing image. Looks good to me.
passing QA... trivial patch, passes QA tests mason@xen1:~/g/head$ koha-qa.pl 10b9097 Bug 8398 - Missing image file in staff global css - starting perlcritic-progressive tests... OK - starting perl -c syntax tests... OK - starting xt/tt_valid.t tests... OK - starting xt/author/vaild-template.t tests... OK
I think this should go to 3.8, but not sure
Pushed to 3.8.x will be in 3.8.3