Bug 7059 - All usage of GetMemberDetails on reserve/request.pl is unnecessary
Summary: All usage of GetMemberDetails on reserve/request.pl is unnecessary
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Ian Walls
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 7058
  Show dependency treegraph
 
Reported: 2011-10-18 22:27 UTC by Ian Walls
Modified: 2013-12-05 20:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (2.46 KB, patch)
2011-10-18 22:34 UTC, Ian Walls
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7059: Remove GetMemberDetails from reserve/request.pl (2.54 KB, patch)
2011-10-19 19:45 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2011-10-18 22:27:30 UTC
Only borrower-table fields are used in any of the 4 calls to GetMemberDetails on reserve/request.pl.  Replacing with GetMember() will be more efficient without any data loss
Comment 1 Ian Walls 2011-10-18 22:34:24 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2011-10-19 19:45:51 UTC
Created attachment 5995 [details] [review]
[SIGNED-OFF] Bug 7059: Remove GetMemberDetails from reserve/request.pl

Replaces all four usages of GetMemberDetails with GetMember, since none of the
hashref fields used were anything other than those in borrower table, which GetMember
returns.

To Test:
1.  Apply patch
2.  Go to reserve/request.pl; the page should load without error
3.  Search for a cardnumber: the page should load without error

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 3 Ian Walls 2011-10-19 22:17:52 UTC
Passed QA, RM please verify
Comment 4 Chris Cormack 2011-10-20 01:08:46 UTC
Pushed, please test
Comment 5 Jared Camins-Esakov 2012-12-31 00:07:10 UTC
There have been no further reports of problems so I am marking this bug resolved.