When affecting a closed basket to a basketgroup, the list shows all the basketgroup, even closed basketgroups.
Created attachment 6784 [details] [review] proposed patch.
It doesn't work. This is how I tested : 1/ i created 2 new baskets with one order line in each. 2/ for the first one, I created a basket group and closed it. I let the second one "free" 3/ I opened a new basket group. 4/ I can see it in the basket group list in the basket page. 5/ But, if I'm on the first basket pag,e I can't see the basket group, this basket is in. Even if it's close, for a specific basket, I should get this info. But, all I have in the list is : "Add new group" and "no group".
Created attachment 11739 [details] [review] Bug 7358: reaffect a closed basket to a closed basketgroup The list of basketgroups when looking at a closed basket show all the basketgroups. It should not be possible to affect a basket to a closed basketgroup, since this basketgroup should have been sent to a supplier.
Created attachment 13228 [details] [review] Bug 7358: reaffect a closed basket to a closed basketgroup The list of basketgroups when looking at a closed basket show all the basketgroups. It should not be possible to affect a basket to a closed basketgroup, since this basketgroup should have been sent to a supplier. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Tested, closed groups no longer selectable and are marked as closed!
QA comment: * introduces new string "(closed)" * passes koha-qa.pl * fixes an annoying problem, even if an unfrequent one Overall: * passed QA * should wait for 3.10.1
Created attachment 13316 [details] [review] Bug 7358: reaffect a closed basket to a closed basketgroup The list of basketgroups when looking at a closed basket show all the basketgroups. It should not be possible to affect a basket to a closed basketgroup, since this basketgroup should have been sent to a supplier. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
I just tested this and was successfully able to add a closed basket to a closed basketgroup both before and after applying the patch.
(In reply to comment #8) > I just tested this and was successfully able to add a closed basket to a > closed basketgroup both before and after applying the patch. Could you detail what you did, because I tested and had no problem
(In reply to comment #9) > (In reply to comment #8) > > I just tested this and was successfully able to add a closed basket to a > > closed basketgroup both before and after applying the patch. > > Could you detail what you did, because I tested and had no problem 1) Created a new basket. 2) Created a new basketgroup for that basket. 3) Closed the basket. 4) Closed the basketgroup. 5) Created a new basket. 6) Closed the new basket. 7) Viewed this new basket, and changed its basketgroup to the basketgroup I had previously created and closed.
(In reply to comment #10) > 7) Viewed this new basket, and changed its basketgroup to the basketgroup I > had previously created and closed. I can't reproduce it neither. At the last step, when I am on the basket detail page (acqui/basket.pl?basketno=XX), the toolbar has 2 buttons ("Reopen this basket" and "Export this basket as CSV") and there is a "Basket group" dropdown list on the right, with 3 options : "no group", "add new group" and "my new basketgroup (closed)". The last one is disabled and cannot be selected
(In reply to comment #11) > (In reply to comment #10) > > 7) Viewed this new basket, and changed its basketgroup to the basketgroup I > > had previously created and closed. > > I can't reproduce it neither. > > At the last step, when I am on the basket detail page > (acqui/basket.pl?basketno=XX), the toolbar has 2 buttons ("Reopen this > basket" and "Export this basket as CSV") and there is a "Basket group" > dropdown list on the right, with 3 options : "no group", "add new group" and > "my new basketgroup (closed)". The last one is disabled and cannot be > selected Did my earlier steps match the expected workflow?
(In reply to comment #12) > Did my earlier steps match the expected workflow? Yes! :-/ In fact only a closed basket can be linked to a basketgroup. You cannot change the basketgroup for a closed basket (unless there is no basketgroup already linked). You cannot add a basket to a basketgroup already closed.
It strikes me the problem might be bug 8892.
(In reply to comment #14) > It strikes me the problem might be bug 8892. Hum, not sure. It works for me using plack.
The patch works for me on current master: 1) Created first order, closed it, attached it to a basket group and closed it. 2) Created second order, closed it, not creating a basket group for it. 3) Tried to changed the basket group, but the closed basket group was greyed out and marked closed. I am not using Plack - not sure where the problem could be.
This patch has been pushed to master. This time I was able to reproduce the problem and confirm the solution. I'm not sure what I was doing wrong before.
Pushed to 3.10.x will be in 3.10.6