Bug 8487 - C4::Installer::PerlDependencies needs Test::Strict hash corrected
Summary: C4::Installer::PerlDependencies needs Test::Strict hash corrected
Status: RESOLVED DUPLICATE of bug 7368
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low critical (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-21 08:05 UTC by Mark Tompsett
Modified: 2012-07-23 06:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line (977 bytes, patch)
2012-07-21 08:39 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Tompsett 2012-07-21 08:05:45 UTC
In my koha development system, I was doing testing:

Valid Cases to check
-------------------------
./koha_perl_deps
./koha_perl_deps -h
./koha_perl_deps -a
./koha_perl_deps -m
./koha_perl_deps -i
./koha_perl_deps -u
./koha_perl_deps -a -c
./koha_perl_deps -m -c
./koha_perl_deps -i -c
./koha_perl_deps -u -c
./koha_perl_deps -m -u
./koha_perl_deps -m -u -c
-------------------------

Invalid Cases to check
-------------------------
./koha_perl_deps -s
./koha_perl_deps -s -u
./koha_perl_deps -s -u -c
-------------------------

Cases 3, 4, 7, 8, 11, and 12 (Numbered from 1 sequentially in the above list) would fail on Test::Strict which is does not have a defined version required.

I thought of patching koha_perl_deps.pl, which bypasses the problem. However, I think the problem lies in the C4::Installer::PerlDependencies module. Only Test::Strict is lacking a 'min_ver'. The 'required' is set to the version number. All other 'required' values are '1' or '0'. This leads me to believe that 'required' should be 'min_ver' and 'required' => '1' be added.
Comment 1 Mark Tompsett 2012-07-21 08:39:14 UTC
Created attachment 11060 [details] [review]
Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line

Before the patch:
koha_perl_deps.pl -a should generate an error on Test::Strict
After the patch:
koha_perl_deps.pl -a should not generate an error on Test::Strict
Comment 2 Chris Cormack 2012-07-22 08:40:33 UTC
(In reply to comment #1)
> Created attachment 11060 [details] [review]
> Added 'require' => '1', and moved old value to a 'min_ver' => '0.14' line
> 
> Before the patch:
> koha_perl_deps.pl -a should generate an error on Test::Strict
> After the patch:
> koha_perl_deps.pl -a should not generate an error on Test::Strict

I'm not sure Test::Strict is required, I think it could be 0. Its only used by one database dependent test, so will not be run when calling make test.

If you rework the patch to make it not required, I'll sign off.
Comment 3 Marcel de Rooy 2012-07-23 06:33:00 UTC
See also bug 7368 latest patch
Comment 4 Mark Tompsett 2012-07-23 06:48:12 UTC
Okay, I see that the patch for bug 7368 does fix this problem as Chris desired. I think I'll mark this as DUPLICATE as a result. Thanks for pointing this out, M. de Rooy.

*** This bug has been marked as a duplicate of bug 7368 ***