Created attachment 7000 [details] [review] Bug 7392: Add system preference to define export options in OPAC NOTE: Patch depends on changes made for Bug 7245 for the "marcstd" option. It adds a new system preference 'OpacExportOptions': The new system preference allows to give a list of | separated values to define, which download options are offered in OPAC. Possible options are listed in the system preference editor and include the new export option 'marcstd' from bug 7245. The sequence of the download options in the system preference will be the sequence in the OPAC pull down. If left empty, the export option will be hidden from OPAC. This patch creates a new include file for the OPAC with all the code that is common to the three detail views (regular, MARC, and ISBD). As a side effect of creating this include file, some inconsistencies in OpacSearchForTitleIn were fixed. {BIBLIONUMBER} and {CONTROLNUMBER} were broken for ISBD and MARC view before and should now be replaced with the correct values in all tabs.
Created attachment 7002 [details] [review] Bug 7392: Add system preference to define export options in OPAC NOTE: Patch depends on changes made for bug 7345 for the "marcstd" option. It adds a new system preference 'OpacExportOptions': The new system preference allows to give a list of | separated values to define, which download options are offered in OPAC. Possible options are listed in the system preference editor and include the new export option 'marcstd' from bug 7345. The sequence of the download options in the system preference will be the sequence in the OPAC pull down. If left empty, the export option will be hidden from OPAC. This patch creates a new include file for the OPAC with all the code that is common to the three detail views (regular, MARC, and ISBD). As a side effect of creating this include file, some inconsistencies in OpacSearchForTitleIn were fixed. {BIBLIONUMBER} and {CONTROLNUMBER} were broken for ISBD and MARC view before and should now be replaced with the correct values in all tabs.
Created attachment 7003 [details] [review] Bug 7392: Add system preference to define export options in OPAC NOTE: Patch depends on changes made for bug 7345 for the "marcstd" option. It adds a new system preference 'OpacExportOptions': The new system preference allows to give a list of | separated values to define, which download options are offered in OPAC. Possible options are listed in the system preference editor and include the new export option 'marcstd' from bug 7345. The sequence of the download options in the system preference will be the sequence in the OPAC pull down. If left empty, the export option will be hidden from OPAC. This patch creates a new include file for the OPAC with all the code that is common to the three detail views (regular, MARC, and ISBD). As a side effect of creating this include file, some inconsistencies in OpacSearchForTitleIn were fixed. {BIBLIONUMBER} and {CONTROLNUMBER} were broken for ISBD and MARC view before and should now be replaced with the correct values in all tabs. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Copy-and-paste qa comment ;) along with Katrin's response already (see 7345 where this mixup started..) Hi Marcel, thx for testing this :) >In the pref file I find a template variable: >Use the CSS stylesheet [% opacthemelang %]/css/ This does not work here. I changed that from the old template syntax to TT - so it probably never worked. Not sure how to make it work? I can take the line change out - but it will still be broken. >OpacExportOptions: It does not really read comfortable in the Preferences >screen. All options exceed the length of the field. Could you extend the field, >make it better readable (new line)? [Is no blocker but a design thing..] It seems the appearance of the field is determined by the type you give in the pref file. I am not sure there is a better type we can use here. The only other option seems to be a box like we use for OpacUserCSS and others? >MARC standard is promised but not delivered yet (while pending on other >report). Does not block this, but you could move it to the report it belongs. I have marked both bugs as dependent on each other. The only thing keeping 7392 from being pushed is the missing presence in the GUI. So I thought I would look into it and it turned into a new feature, going beyond a simple follow-up. >Just a thought: If you add an unexisting format, it now comes in the list and >you will have an error message on screen. Would it be interesting to exclude >these formats (question with some doubts on my part too).. I can make them not show up - that's probably the easiest way to solve this.
(In reply to comment #4) > I changed that from the old template syntax to TT - so it probably never > worked. Not sure how to make it work? I can take the line change out - but it > will still be broken. I suggest that you still edit this line, but you could describe something like css subfolder in the templates themelanguage subfolder blabla.. > It seems the appearance of the field is determined by the type you give in the > pref file. I am not sure there is a better type we can use here. The only other > option seems to be a box like we use for OpacUserCSS and others? Don't touch it then. We could leave it to the design experts to adjust with a follow-up. > I can make them not show up - that's probably the easiest way to solve this. Well, if you could make a small adjustment for that now, please do.. Looking forward to the new patch. THANKS.
Created attachment 7157 [details] [review] Bug 7392: Add system preference to define export options in OPAC NOTE: Patch depends on changes made for bug 7345 for the "marcstd" option. It adds a new system preference 'OpacExportOptions': The new system preference allows to give a list of | separated values to define, which download options are offered in OPAC. Possible options are listed in the system preference editor and include the new export option 'marcstd' from bug 7345. The sequence of the download options in the system preference will be the sequence in the OPAC pull down. If left empty, the export option will be hidden from OPAC. This patch creates a new include file for the OPAC with all the code that is common to the three detail views (regular, MARC, and ISBD). As a side effect of creating this include file, some inconsistencies in OpacSearchForTitleIn were fixed. {BIBLIONUMBER} and {CONTROLNUMBER} were broken for ISBD and MARC view before and should now be replaced with the correct values in all tabs. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 7158 [details] [review] Bug 7392: Follow-up Patch makes changes according to QA comments: - entering an unknown format code will generate no entry in the OPAC pull down - small change to the description of opaclayoutstylesheet system preference
Created attachment 7159 [details] [review] Bug 7392: Follow-up Patch makes changes according to QA comments: - entering an unknown format code will generate no entry in the OPAC pull down - small change to the description of opaclayoutstylesheet system preference Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 7170 [details] [review] [SIGNED-OFF][REBASED] Add syspref to define export options in OPAC Rebased.
Created attachment 7171 [details] [review] Second followup for pref description Updating text only for description of opaccolorstylesheet and opaclayoutstylesheet.
QA Comment: Requested points have been incorporated. I added a textual change to get the descriptions for two opac css sysprefs in line with each other. Updating patch status.
Sorry, still does not work. When trying to apply the [SIGNED-OFF][REBASED] Add syspref to define export options in OPAC, I get a nasty: Patch format detection failed. really sorry... opening the patch, I see unusal end of line (^M)
Created attachment 7571 [details] [review] Bug 7345: Follow up: Adding the new export option to staff interface NOTE: Patch depends on changes made for bug 7345 for the "marcstd" option. It adds a new system preference 'OpacExportOptions': The new system preference allows to give a list of | separated values to define, which download options are offered in OPAC. Possible options are listed in the system preference editor and include the new export option 'marcstd' from bug 7345. The sequence of the download options in the system preference will be the sequence in the OPAC pull down. If left empty, the export option will be hidden from OPAC. This patch creates a new include file for the OPAC with all the code that is common to the three detail views (regular, MARC, and ISBD). As a side effect of creating this include file, some inconsistencies in OpacSearchForTitleIn were fixed. {BIBLIONUMBER} and {CONTROLNUMBER} were broken for ISBD and MARC view before and should now be replaced with the correct values in all tabs. Patch makes changes according to QA comments: - entering an unknown format code will generate no entry in the OPAC pull down - small change to the description of opaclayoutstylesheet system preference - Updating text only for description of opaccolorstylesheet and opaclayoutstylesheet. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Resolved merge conflicts on sysprefs.sql and updatedatabase.pl. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Something strange happened here with the attachments. Looking at it now!
Created attachment 7608 [details] [review] Rebased patch
Created attachment 7609 [details] [review] Follow-up 1
Created attachment 7610 [details] [review] Follow-up 2
Paul, I could not find the unusual line. But the last attachment after that had some problems (mixup with 7345). But I have rebased the base patch for this report now. That should be pushed first and the two other followups in the given order. Please consider pushing this report first before another one with a dbrev. It is in the Passed QA already for some time now..
While testing before pushing those patches, I fall in a problem that either means there's a bug or some documentation is needed. I switched the syspref to: bibtex|dc|marcxml|marc8|utf8|marcstd|mods|ris => I get the "Save record" list with MARC (non unicode/MARC8) / MARC (Unicode/UTF8) / MARC (Unicode UTF8/Standard) I can export my record and it includes all 9xx fields (including 995, where the item(s) are) The I switched the syspref to "empty" = the list disappear on the OPAC, expected behaviour Then I switched the syspref to: bibtex|dc|marcxml|marc8|utf8|9xx|mods|ris Then ... I understood that the (9xx,x9x, xx9) are not related to the format as are other () in the syspref description => i'll do a follow-up before pushing to say Note: Available options are: BIBTEX (bibtex), Dublin Core (dc), MARCXML (marcxml), MARC-8 encoded MARC (marc8), Unicode/UTF-8 encoded MARC (utf8), Unicode/UTF-8 encoded MARC without local use -9xx, x9x, xx9- fields and subfields (marcstd), MODS (mods), RIS (ris) it will be more clear Then I tried to upload a marcstd record, and got exactly the same result as for utf8 or marcxml record: I get the 995 (item) and the 090(biblionumber) fields as well. Am I not supposed not to get them ? what am I doing wrong ?
Created attachment 7616 [details] [review] Follow up 3 for marcstd typo
Follow-up (comment 20) from marcelr is a consequence of the comment 19, and fixes the problem I rised, and that was confirmed by a discussion on IRC. This patch has been pushed with the 7345, it can't be found in new/bug_7392 branch, it is in new/bug_7345
Created attachment 10339 [details] [review] [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=5356
Comment on attachment 10339 [details] [review] [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" wrong bug number, sorry!
There have been no further reports of problems so I am marking this bug resolved.