Bug 7505 - Superlibrarian can't export all biblios when IndependantBranches is enabled
Summary: Superlibrarian can't export all biblios when IndependantBranches is enabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low minor (vote)
Assignee: Frédéric Demians
QA Contact: Ian Walls
URL:
Keywords:
: 3002 6301 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-06 18:57 UTC by Frédéric Demians
Modified: 2014-05-26 21:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.68 KB, patch)
2012-02-06 19:06 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 7505 Superlibrarian can't export all biblios when IndependantBranches is enabled (1.78 KB, patch)
2012-02-07 14:48 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2012-02-06 18:57:22 UTC
When a Koha user has superlibrarian permissions, and if
IndependantBranches is enabled, in Tools > Export bibliographic and
holdings, this user can't export all biblio records. He will just export
the biblio from the branch he belongs to.
Comment 1 Frédéric Demians 2012-02-06 19:06:46 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2012-02-07 14:48:21 UTC
Created attachment 7476 [details] [review]
Bug 7505 Superlibrarian can't export all biblios when IndependantBranches is enabled

When a Koha user has superlibrarian permissions, and if
IndependantBranches is enabled, in Tools > Export bibliographic and
holdings, this user can't export all biblio records. He will just export
the biblio from the branch he belongs to.

This patch fix that.

To test:

  - Do a ALL records export as superlibrian on a multi-branches Koha instance
  - Examine the resulting MARC file with the tool of your choice (MArcEdit,
    yaz-marcdump, etc.)
  - You will see that 952/995 contains exlusively items from your branch (as
    Koha user)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 3 Ian Walls 2012-02-07 16:53:42 UTC
Uses bitwise AND syntax for permission check (preferred method), and adds check to export function as necessary to solve the issue.  Marking Passed QA.
Comment 4 Katrin Fischer 2012-04-07 16:56:55 UTC
*** Bug 3002 has been marked as a duplicate of this bug. ***
Comment 5 Jared Camins-Esakov 2012-05-24 00:52:03 UTC
This patch was incorporated into 3.6.x prior to 3.6.4.
Comment 6 Liz Rea 2013-07-29 04:05:09 UTC
*** Bug 6301 has been marked as a duplicate of this bug. ***