To reproduce: - Enter a new subscription in serials, make sure the manual history checkbox is not touched and no data is entered in that section. - The serial summary page will show 'Manual history: Enabled' - Editing the subscription will always show the manual history fields expanded.
This was previously reported and supposedly fixed on bug 3908.
Created attachment 15210 [details] [review] Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch.
Created attachment 15260 [details] [review] [SIGNED-OFF] Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment: Works as advertised. Note that a complete rewrite of this part of code is waiting sign-off (Bug 7688). Marked as Passed QA.
Created attachment 15275 [details] [review] Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
No string changes pushed to 3.10.x will be in 3.10.3