Bug 7608 - Manual history is always 'enabled'
Summary: Manual history is always 'enabled'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jared Camins-Esakov
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-26 17:22 UTC by Katrin Fischer
Modified: 2014-02-26 07:00 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7608: Manual history should not always be enabled (1.68 KB, patch)
2013-02-10 18:44 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7608: Manual history should not always be enabled (1.79 KB, patch)
2013-02-11 19:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 7608: Manual history should not always be enabled (1.80 KB, patch)
2013-02-12 15:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-02-26 17:22:24 UTC
To reproduce:

- Enter a new subscription in serials, make sure the manual history checkbox is not touched and no data is entered in that section.

- The serial summary page will show 'Manual history: Enabled'

- Editing the subscription will always show the manual history fields expanded.
Comment 1 Jared Camins-Esakov 2013-02-10 18:42:13 UTC
This was previously reported and supposedly fixed on bug 3908.
Comment 2 Jared Camins-Esakov 2013-02-10 18:44:58 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-02-11 19:46:56 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-02-12 15:51:54 UTC
QA comment:

Works as advertised.

Note that a complete rewrite of this part of code is waiting sign-off (Bug 7688).

Marked as Passed QA.
Comment 5 Jonathan Druart 2013-02-12 15:52:09 UTC
Created attachment 15275 [details] [review]
Bug 7608: Manual history should not always be enabled

When editing a subscription, the "manual history" block is visible even
if the subscription was created with manual history off.

To test:
1) Create a subscription and do not check the "Manual history" checkbox.
2) Save the subscription.
3) Edit the subscription. Note that the manual history section does not
   appear.
4) Enable manual history. Note the appearance of the manual history
   section.
5) Save the subscription.
6) Edit the subscription. Note that the manual history section appears.
7) Click "[cancel manual history]". Note the disappearance of the manual
   history section, and the unchecking of the "Manual history" checkbox.
8) Sign off on patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Jared Camins-Esakov 2013-02-15 12:47:11 UTC
This patch has been pushed to master.
Comment 7 Chris Cormack 2013-02-16 05:31:51 UTC
No string changes pushed to 3.10.x will be in 3.10.3