Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location! I propose we add the home branch to this column in the event that it differs from the holding branch.
Created attachment 8213 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. In the event that an item's homebranch and holding branch differ, this commit will add an "Owned by" for the homebranch directly below the current location branch. This also solves the shelving location ambiguity, as the shelving location will now always be below the library where the item's shelving location is used.
Created attachment 8215 [details] Screenshot showing updated interface I agree that the current display is ambiguous. When we originally designed it this way the goal was simplicity for the sake of patron-friendliness: Why show the user information about where the item *isn't*? But it's obviously more complicated than that for a lot of libraries and users. I think a solution is needed but I'm not sure this is it. I find this a little bit hard for my eye to scan. Is the patron going to understand what "owned by" means in this context?
Do we actually have any data collected from patrons about the usability of these terms and layout, or are we just guessing? I agree that it can be confusing to have two libraries listed, as the item can only be one place at a time, but I'd recommend we get some kind of hard data first before we go and make this kind of change.
I think perhaps this is something we will need some configuraton options for. I can imagine that for different library system different things can make sense. I would guess the patron wants to know where he can find the item. If we show owning library and the library uses floating collections, so the item stays at the library where it was last borrowed, the owning library will not be interesting for the patron. If the book is always transfered back to the owning library after filling a hold at another branch, it might only confuse the patron to see where the item is right now. I think showing 2 branches only makes sense under certain circumstances and not sure it will be confusing for the patron.
(In reply to comment #3) It's a guess. This was the best layout I was able to think up at the time. I would be more than happy to make this a system preference-able feature. If you have any other ideas, please let me know. > Do we actually have any data collected from patrons about the usability of > these terms and layout, or are we just guessing? I agree that it can be > confusing to have two libraries listed, as the item can only be one place at > a time, but I'd recommend we get some kind of hard data first before we go > and make this kind of change.
Created attachment 8216 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. In the event that an item's homebranch and holding branch differ, this commit will add an "Owned by" for the homebranch directly below the current location branch. This also solves the shelving location ambiguity, as the shelving location will now always be below the library where the item's shelving location is used.
Just an fyi, but I've now had multiple libraries complain about the current presentation of the location. I think this is a real usability issue that needs to be addressed.
Created attachment 8223 [details] new screenshot of clearer display
Created attachment 8224 [details] new screenshot of clearer display
I think the new display is better than it first was, but it's still a bit confusing if you have a shelving location in there as well. I unfortunatly don't have a better suggestion though ... except maybe to say 'Owned by: library, shelved at: location' .... other ideas?
Created attachment 8226 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only.
Created attachment 8229 [details] Screenshot of OPAC with new columns.
Created attachment 8230 [details] [review] [SIGNED-OFF] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Searched in the OPAC and checked the details page for several titles. All tests passed.
Much clearer. Signing off.
Hi All, We're the ones that raised this issue and Kyle kindly created a first shot at a fix. We would rather just have the owning library listed in the OPAC and then list it's availability status as the system does now. So if the item is loaned from Library A to Library B, it is still showing as owned by Library A, but "checked out" or "in transit" or whatever stage of the hold fulfillment process it is in. It doesn't seem necessary to us to muddy the waters in the OPAC with the level of detail of "this is owned by Library A but being used by Library B right now." We can get that level of information from the staff side with the "Current Location" and "Home Library" columns. That seems like enough. What we're finding is that patrons at our member libraries are getting confused with the current display. They're thinking that their library doesn't own an item because it displays as having a 'current location' of another library when it has been loaned to another library in the consortium. So the patrons are thinking that the library doesn't own the title and the libraries can come off as looking bad, "why don't we own a copy of 'The Help?' " I have no idea if this is helpful, but we'd rather see the owning library as the only library information listed in the OPAC. We think providing the current location information in the OPAC only makes for misinformation and confusion with patrons. Thanks, Nora Blake MassCat
Future enhancement idea for this - make it so that single branch systems can hide the home library column in staff and opac :)
(In reply to comment #15) > I have no idea if this is helpful, but we'd rather see the owning library as > the only library information listed in the OPAC. We think providing the > current location information in the OPAC only makes for misinformation and > confusion with patrons. I don't think this is possible because so many libraries using Koha have had it this way forever and so they're used to seeing the holding branch. They have trained their patrons to know what they're seeing. I don't think we should switch the view without a system preference to let the library choose. This way at least lets you see what you want and the other libraries see what they want. PS. I comment before this was written while you were writing yours :)
So then what about a system pref that would allow libraries to choose to display only owning library or holding library info? Nora Blake MassCat
Created attachment 8237 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System Preference This commit adds the system preference OpacLocationBranchToDisplay which allows a library to control whether to display the holding library, the home library, or both for the opac details page. http://bugs.koha-community.org/show_bug.cgi?id=7220
Created attachment 8238 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System Preference This commit adds the system preference OpacLocationBranchToDisplay which allows a library to control whether to display the holding library, the home library, or both for the opac details page. http://bugs.koha-community.org/show_bug.cgi?id=7220
Kyle, I can't apply your follow up - does it go after the patch I signed off on? or does it replace it? Applying: Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System Preference /home/nengard/kohaclone/.git/rebase-apply/patch:49: trailing whitespace. home: "home library" /home/nengard/kohaclone/.git/rebase-apply/patch:92: trailing whitespace. /home/nengard/kohaclone/.git/rebase-apply/patch:99: space before tab in indent. <a href="[% ITEM_RESULT.homebranchurl %]">[% ITEM_RESULT.homebranchname %]</a> /home/nengard/kohaclone/.git/rebase-apply/patch:102: trailing whitespace. [% END %] error: patch failed: installer/data/mysql/sysprefs.sql:347 error: installer/data/mysql/sysprefs.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:4910 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System Preference When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7720---Ambiguity-in-OPAC-Details-location---Fo-pwHrf1.patch
Created attachment 8243 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System Preference This commit adds the system preference OpacLocationBranchToDisplay which allows a library to control whether to display the holding library, the home library, or both for the opac details page. http://bugs.koha-community.org/show_bug.cgi?id=7220
The new patch is a followup, so it will need to be applied on top of the previous patch.
Created attachment 8245 [details] [review] [SIGNED-OFF] Bug 7720 - Ambiguity in OPAC Details location - Followup - Add System Preference This commit adds the system preference OpacLocationBranchToDisplay which allows a library to control whether to display the holding library, the home library, or both for the opac details page. http://bugs.koha-community.org/show_bug.cgi?id=7220 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> tested preference with all values and it works as expected.
QA Comments: The patch does not apply on the current master. Moreover, there is a lot of tabulation characters in your patch (in opac-detail.tt). Please replace them with 4 spaces. Marked as Failed QA
Created attachment 8825 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds the system preference OpacLocationBranchToDisplay which allows a library to control whether to display the holding library, the home library, or both for the opac details page. http://bugs.koha-community.org/show_bug.cgi?id=7220
Created attachment 8868 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds the system preference OpacLocationBranchToDisplay which allows a library to control whether to display the holding library, the home library, or both for the opac details page. http://bugs.koha-community.org/show_bug.cgi?id=7220
Created attachment 8878 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
Patch will not apply - Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Items.pm Failed to merge in the changes. Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location.
Created attachment 9570 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
i try to apply this patch in a sandbox but i don't see the sys pref OpacLocationBranchToDisplay and OpacLocationBranchToDisplayShelving in my koha
Created attachment 9762 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
The previous iteration of this patch ahd $DBversion = "3.07.00.XXX" in updatedatabase.pl, and thus the update was being skipped over. This new one should work.
Patch doesn't apply : Bug 7720 - Ambiguity in OPAC Details location. Apply? [yn] y Applying: Bug 7720 - Ambiguity in OPAC Details location. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Items.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging opac/opac-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7720---Ambiguity-in-OPAC-Details-location-CmCdA1.patch
Created attachment 10149 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
This needs to be rebased. Also looks like there's a conflict marker somewhere? +<<<<<<< HEAD
Created attachment 11091 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
Created attachment 11092 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
I think Kyle forgot to change the status... Changing status to "needs signoff" for the new patch from 7/23.
Tested these conditions: OpacLocationBranchToDisplay = holding library OpacLocationBranchToDisplayShelving = holding library - Only holding library displays, shelving location is shown OpacLocationBranchToDisplay = holding library OpacLocationBranchToDisplayShelving = home and holding library - Only holding library displays, shelving location is shown (same as previous) OpacLocationBranchToDisplay = holding library OpacLocationBranchToDisplayShelving = home library - Only holding library displays, shelving location is not shown OpacLocationBranchToDisplay = home library OpacLocationBranchToDisplayShelving = holding library - Only home library displays, shelving location is not shown OpacLocationBranchToDisplay = home library OpacLocationBranchToDisplayShelving = home and holding library - Only home library displays, shelving location is shown OpacLocationBranchToDisplay = home library OpacLocationBranchToDisplayShelving = home library - Only home library displays, shelving location is shown (same as previous) OpacLocationBranchToDisplay = home and holding library OpacLocationBranchToDisplayShelving = holding library - Home and holding libraries display, shelving location shown with holding OpacLocationBranchToDisplay = home and holding library OpacLocationBranchToDisplayShelving = home and holding library - Home and holding libraries display, shelving location shown with both OpacLocationBranchToDisplay = home and holding library OpacLocationBranchToDisplayShelving = home library - Home and holding libraries display, shelving location shown with home Functionally this seems to be working as expected. There are a couple of peripheral issues which need to be corrected: - The column of item-level holds is not displayed. Even in cases where there is an item-level hold the column is empty. - The patch violates capitalization guidelines (Bug 2780) ("Current location" and "Home Library").
Created attachment 12389 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
> - The column of item-level holds is not displayed. Even in cases where there > is an item-level hold the column is empty. I'm not sure what you are referring to here. Could you post an before/after screenshot? > - The patch violates capitalization guidelines (Bug 2780) ("Current > location" and "Home Library"). Fixed.
Please look at: --- a/installer/data/mysql/sysprefs.sql +++ b/installer/data/mysql/sysprefs.sql +<<<<<<< HEAD
Created attachment 13466 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
Fixed! (In reply to comment #43) > Please look at: > --- a/installer/data/mysql/sysprefs.sql > +++ b/installer/data/mysql/sysprefs.sql > +<<<<<<< HEAD
This patch no longer applies.
Created attachment 15237 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
Created attachment 15238 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556
Created attachment 15241 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both.
Created attachment 15247 [details] [review] [SIGNED-OFF] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Tested all variations. No koha-qa errors.
# both modified: installer/data/mysql/sysprefs.sql # both modified: installer/data/mysql/updatedatabase.pl # both modified: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Patch doesn't apply cleanly, I could fix the first 2 files, but unsure on the 3rd one, Kyle can you rebase and set back to signed off please
Created attachment 18622 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Tested all variations. No koha-qa errors.
Hi Kyle, could you take a look at the conflicts please and submit a new rebased patch? Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 7720 - Ambiguity in OPAC Details location. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort".
Created attachment 19658 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Tested all variations. No koha-qa errors.
QA comment: Kyle, could you provide a version of this patch using the branches template plugin? Like that, I think you could delete the sql query in C4::Items::GetItemsInfo. Marked as Failed QA.
Created attachment 20217 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - QA Followup
Kyle, first patch does not apply cleanly (conflicts in opac-detail.tt).
Created attachment 21374 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Tested all variations. No koha-qa errors.
Created attachment 21375 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - QA Followup
Created attachment 22155 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Tested all variations. No koha-qa errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 22156 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - QA Followup Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Works as described. Code looks good to me. Passed QA Just a few side-notes: Can we prevent constructions like [% IF ( Branches.GetURL( ITEM_RESULT.homebranch ) ) %] <a href="[% Branches.GetURL( ITEM_RESULT.homebranch ) %]">[% Branches.GetName( ITEM_RESULT.homebranch ) %]</a> making repeated calls to same function? The code for showing shelf loc also relies heavily on having 1) the shelf loc obviously, 2) having auth val LOC on that field and 3) in that particular framework. I had something in location, but it would not show up until I realized that the biblio was in another framework :) GetURL includes a statement: return encode( 'UTF-8', $b->{'branchurl'} ); It works, but (outside the scope of this report) it would be even better if we should not need them at that spot. Referring further to encoding problems/discussions..
This needs a Bootstrap follow-up, and unfortunately that looks to be non-trivial.
Created attachment 28172 [details] [review] Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Tested all variations. No koha-qa errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 28173 [details] [review] Bug 7720 - Ambiguity in OPAC Details location - QA Followup Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 28175 [details] [review] Bug 7720 [QA Followup] - Update Bootstrap theme Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Setting to Passed QA since the bootstrap followup appears to be the only blocker for this. I've tested every combination of the system preferences for the bootstrap followup, and it looks good!
Pushed to master, along with follow-ups. Thanks, Kyle!
(In reply to Galen Charlton from comment #68) > Pushed to master, along with follow-ups. Thanks, Kyle! Enhancement, skipping patch for 3.16.x series