Bug 7837 - nb-NO z3950servers.sql misses column names
Summary: nb-NO z3950servers.sql misses column names
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal
Assignee: Magnus Enger
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 19:51 UTC by Magnus Enger
Modified: 2013-12-05 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 7837 - nb-NO z3950servers.sql misses column names (2.37 KB, patch)
2012-03-27 20:36 UTC, Magnus Enger 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7837 - nb-NO z3950servers.sql misses column names (2.52 KB, patch)
2012-03-28 06:20 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2012-03-27 19:51:04 UTC 
As noted by Katrin on Bug 7436: 

ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1

This is caused by a change to the z3950servers table, and the nb-NO z3950servers.sql file being in terrible form: 

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql;h=cb0ce50823f423b7efe72441cb03b6c983287332;hb=HEAD

NSERT INTO `z3950servers` VALUES 
('z3950.loc.gov',7090,'Voyager','','','LIBRARY OF CONGRESS',1,0,0,'USMARC',NULL,'primary','zed','MARC-8','') etc...

Patch coming!
Comment 1 Magnus Enger 2012-03-27 20:36:43 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-03-28 06:20:48 UTC 
Created attachment 8662 [details] [review]
[SIGNED-OFF] Bug 7837 - nb-NO z3950servers.sql misses column names

Fix installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql so it
includes column names.

To test:
- Install the nb-NO language
- Run through the web installer, and make sure to select the optional
  ("Valgfritt") z3950servers.sql file
- Check there are no errors
- Check that the Z39.50 errors are displayed OK in
  Home › Administration › Z39.50 Servers

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Web installer runs without any errors now and I checked that
the Z39.50 servers were imported correctly and can be edited.
Comment 3 Marcel de Rooy 2012-03-28 11:57:23 UTC 
QA Comment: Looks good to me.
Comment 4 Paul Poulain 2012-03-28 14:22:22 UTC 
pushed, not tested myself but looks OK and magnus will fix any problem quickly ;-)
Comment 5 Jared Camins-Esakov 2012-05-09 20:03:28 UTC 
This bug will be included in the Koha 3.6.5 release.
Comment 6 Jared Camins-Esakov 2012-05-10 13:05:43 UTC 
This bug will NOT be included in the Koha 3.6.5 release. Apologies for the confusion. It was unnecessary.