Bug 8160 - Link to cataloging appears for users without cataloging permission
Summary: Link to cataloging appears for users without cataloging permission
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on: 8161
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-29 15:20 UTC by Owen Leonard
Modified: 2013-12-05 19:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8160 - Link to cataloging appears for users without cataloging permission (2.46 KB, patch)
2012-05-29 20:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8160 - Link to cataloging appears for users without cataloging permission (2.49 KB, patch)
2012-06-01 23:07 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-05-29 15:20:13 UTC
Users without cataloging permission should not see the cataloging link.
Comment 1 Owen Leonard 2012-05-29 20:15:08 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-06-01 23:07:26 UTC
Created attachment 9898 [details] [review]
Bug 8160 - Link to cataloging appears for users without cataloging permission

This patch wraps cataloging links on the staff client home
page and in the header menu with checks for edit_catalogue
OR edit_items permission.

To test, access the staff client as a user with various
permissions. The "cataloging" link on the main page and
in the header menu should only appear to a user with
edit_catalogue permission, edit_items permission, or both.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Ian Walls 2012-06-04 16:58:00 UTC
Makes permissions check for display of cataloging page consistent and logical (user must have catalog or item editing permissions to get to the page where one can do that...)

Passed QA.
Comment 4 Chris Cormack 2012-06-05 19:51:23 UTC
Pushed to 3.8.x, will be in 3.8.2